645793 - configure should be permitted to disable gconf support all together

Status: RESOLVED INVALID

(Firefox Build System :: General, defect)

Description

[Jory A. Pratt [:anarchy]]

Attachment: allow disabling gconf support.

Configure should not automagically add gconf support if the user does not run gnome. Gconf is only used to set the default browser which is only useful for gnome-2.x users. Attached is a patch that will permit the user to disable gconf support if they do not need/want it.

Comment 1

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/038340b47ab9

I assume we don't necessary need this in 2.0 if we release 2.2 in less than 3 months now.

Comment 2

[Jory A. Pratt [:anarchy]]

Attachment: finish disabling gconf support if requested

Reopened until we get a solution or current patch approved.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 543685 [details] [diff] [review]
finish disabling gconf support if requested

This looks good ... I hope you've tested it ;-)

r=me

Comment 4

[Jory A. Pratt [:anarchy]]

(In reply to comment #3)
> Comment on attachment 543685 [details] [diff] [review] [review]
> finish disabling gconf support if requested
> 
> This looks good ... I hope you've tested it ;-)
> 
> r=me

I have tested it :b throughly to ensure that no instance of gconf is fired up from the browser :)

Comment 5

[Daniel Holbert [:dholbert]]

If you could add author & commit-message metadata to the patch, as described here...
https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3f
...that will help this get checked in faster (by making things easier for whoever ends up volunteering to check it in).

Comment 6

[Jory A. Pratt [:anarchy]]

Attachment: Finish removing gconf support when requested

Carrying over review, updated summary and author as requested by Daniel

Comment 7

[Dão Gottwald [:dao]]

Unclear what needs to be checked in here. Please mark obsolete patches as obsolete. I assumed I should only import the third patch, but it fails to apply on mozilla-central tip.

Comment 8

[Daniel Holbert [:dholbert]]

Landed:
  http://hg.mozilla.org/integration/mozilla-inbound/rev/1f8010810cee
(first patch was landed already in comment 1, and second patch == third patch modulo commit headers.  3rd patch applies fine with fuzz, & I verified manually that the fuzz did the right thing.)

Comment 9

[Marco Bonardo [:mak]]

backed out because it was compiling only on Linux

Comment 10

[Marco Bonardo [:mak]]

look like the #else in nsStaticXULComponents.cpp is serving the wrong ifdef?

Comment 11

[Daniel Holbert [:dholbert]]

Yup - the build failure is about missing SYSTEMPREF_MODULES in that file, which is what that ifdef/else area guards.
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1310113963.1310114729.14446.gz

Jory, could you fix that & rebase the patch?

Comment 12

[Jory A. Pratt [:anarchy]]

(In reply to comment #11)
> Yup - the build failure is about missing SYSTEMPREF_MODULES in that file,
> which is what that ifdef/else area guards.
> http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1310113963.
> 1310114729.14446.gz
> 
> Jory, could you fix that & rebase the patch?

Yeah I will fix it, be this weekend before I can get to it tho sorry for the inconvience.

Comment 13

[Jory A. Pratt [:anarchy]]

Work is invalid with latest trunk builds. If the need arises I will rework everything until that time closing.