64593 - javascript strict warnings in nsTreeUtils.js

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P2)

Description

[Henrik Gemal]

JavaScript strict warning:
chrome://global/content/nsTreeUtils.js line 374: assignment to undeclared variab
le cmdNameLiteral

JavaScript strict warning:
chrome://global/content/nsTreeUtils.js line 376: assignment to undeclared variab
le cmdName

Comment 1

[Mark Olson]

Attachment: patch - fix strict warnings

Comment 2

[Blake Ross]

cc'ing alec for sr

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

a=[e-mail]

Comment 4

[timeless]

r=timeless

Comment 5

[timeless]

fix checked in.

Comment 6

[Henrik Gemal]

Now I'm getting:
JavaScript error:
chrome://global/content/nsTreeUtils.js line 264: debug is not defined

Comment 7

[Alec Flett]

fixed in today's build, sorry 'bout that.

Comment 8

[Henrik Gemal]

todays build...:

JavaScript error:
chrome://global/content/nsTreeUtils.js line 229: menuitem has no properties

Comment 9

[Alec Flett]

*sigh* I have a fix in my tree for this, attaching a patch.

Comment 10

[Alec Flett]

Attachment: fix error

Comment 11

[Ben Goodger (use ben at mozilla dot org for email)]

a=[e-mail]

Comment 12

[Alec Flett]

checked in.

Comment 13

[Henrik Gemal]

verified with build 20010126 on win2k

Comment 14

[Henrik Gemal]

When right-clicking on a bookmark in the bookmark sidebar:

JavaScript error:
 line 0: uncaught exception: [Exception... "Component returned failure code:
0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]"  nsresult:
"0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame ::
chrome://global/content/nsTreeUtils.js :: get_localized_string :: line 502" 
data: no]