Closed Bug 645982 Opened 13 years ago Closed 8 years ago

Possible error in code

Categories

(Mozilla Labs Graveyard :: Test Pilot, defect)

Product:
Mozilla Labs Graveyard
Component:
Test Pilot
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: brunner.adam, Assigned: jono)

Details

(Whiteboard: needs-integration)

Attachments

(1 file)

Patch applying Adam's change
911 bytes, patch
mfinkle
: review+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2.16) Gecko/20110319 Firefox/3.6.16
Build Identifier: 

In the file "testpilot@labs.mozilla.com/modules/feedback.js" in line 110, there is the following code:
      if (path.indexOf("feedback" > -1) || path.indexOf("happy" > -1) || path.indexOf("sad" > -1)) {

This should be
      if (path.indexOf("feedback") > -1 || path.indexOf("happy") > -1 || path.indexOf("sad") > -1) {

Please note the closing parenthesis.

This could possible lead to this exception I get every page request:
Error: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIURI.host]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: file:///Users/USERNAME/Library/Application%20Support/Firefox/Profiles/viay3fgv.Firefox3.6/extensions/testpilot@labs.mozilla.com/modules/feedback.js :: FeedbackManager_isInputUrl :: line 109"  data: no]

Reproducible: Always




I use Test Pilot 1.1 under Firefox 3.6.16.
Hi Adam,
Thanks for catching this!  I'm not sure how I missed it.
I applied your patch in http://hg.mozilla.org/labs/testpilot/rev/9392605bd674

Thanks again.
Status: UNCONFIRMED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
I think we should thank all your work! ;)
Assignee: nobody → jdicarlo
Status: RESOLVED → REOPENED
Ever confirmed: true

        Attachment #524920 -
        Flags: review?(mark.finkle)
Resolution: FIXED → ---

    
  
Whiteboard: needs-integration

        Attachment #524920 -
        Flags: review?(mark.finkle) → review+

    
    

    
  
mfinkle: Is this landed?
Product: Mozilla Labs → Mozilla Labs Graveyard

    
    

    
  
decommissioned
Status: REOPENED → RESOLVED
Closed: 13 years ago → 8 years ago
Resolution: --- → WONTFIX

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: