Closed Bug 646070 Opened 13 years ago Closed 13 years ago

Respect chrome developer tools preference in workspace

Categories

(DevTools :: General, defect)

Product:
DevTools
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Firefox 6

People

(Reporter: rcampbell, Assigned: msucan)

References

Details

(Whiteboard: [workspace][patchclean:0420][fixed-in-devtools][merged-to-mozilla-central])

Attachments

(1 file, 2 obsolete files)

[checked-in][in-devtools] rebased patch
11.38 KB, patch
Details | Diff | Splinter Review 
We should have a global preference for enabling chrome development that all of the developer tools respect.

For the Workspace, we should disable the "Context" menu with this preference disabled and show it when enabled.

I think the pref should be called something like "devtools.chrome.enabled"
Taking the bug.
Assignee: nobody → mihai.sucan
Attached patch proposed patch (obsolete) — — Splinter Review 
Proposed patch with a mochitest included.

Please note that this patch requires the patches from bug 636725 and bug 642176.

Looking forward to your feedback!
Attachment #525482 - Flags: feedback?(rcampbell)
Status: NEW → ASSIGNED
Depends on: 636725, 642176
Whiteboard: [workspace] → [workspace][patchclean:0412]
Comment on attachment 525482 [details] [diff] [review]
proposed patch

I think this looks OK.
Attachment #525482 - Flags: feedback?(rcampbell) → feedback+
Attached patch updated patch (obsolete) — — Splinter Review 
Updated the patch. Rebased on top of the latest attachment 526358 [details] [diff] [review] from bug 636725 and I also made changes based on previous review comments.

Thanks for the feedback+ Robert!
Attachment #525482 - Attachment is obsolete: true
Attachment #526360 - Flags: review?(sdwilsh)
Whiteboard: [workspace][patchclean:0412] → [workspace][patchclean:0415]
Blocks: 646524
Comment on attachment 526360 [details] [diff] [review]
updated patch

r=sdwilsh
Attachment #526360 - Flags: review?(sdwilsh) → review+
Shawn, thanks for the r+!
Whiteboard: [workspace][patchclean:0415] → [workspace][patchclean:0415][checkin][requires-dependencies]
Rebased the patch.
Attachment #526360 - Attachment is obsolete: true
Whiteboard: [workspace][patchclean:0415][checkin][requires-dependencies] → [workspace][patchclean:0420][checkin][requires-dependencies]
Whiteboard: [workspace][patchclean:0420][checkin][requires-dependencies] → [workspace][patchclean:0420][fixed-in-devtools][requires-dependencies]
Comment on attachment 527215 [details] [diff] [review]
[checked-in][in-devtools] rebased patch

http://hg.mozilla.org/projects/devtools/rev/8227473480f5
Attachment #527215 - Attachment description: rebased patch → [in-devtools] rebased patch
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [workspace][patchclean:0420][fixed-in-devtools][requires-dependencies] → [workspace][patchclean:0420][fixed-in-devtools][merged-to-mozilla-central]
Target Milestone: --- → Firefox 6
Comment on attachment 527215 [details] [diff] [review]
[checked-in][in-devtools] rebased patch

http://hg.mozilla.org/mozilla-central/rev/8227473480f5
Attachment #527215 - Attachment description: [in-devtools] rebased patch → [checked-in][in-devtools] rebased patch
Verified fixed on:
Windows 7:
Mozilla/5.0 (Windows NT 6.1; rv:6.0a2) Gecko/20110525 Firefox/6.0a2
Window XP:
Mozilla/5.0 (Windows NT 5.1; rv:6.0a2) Gecko/20110525 Firefox/6.0a2
Mac OS 10.6
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:6.0a2) Gecko/20110525 Firefox/6.0a2 
Linux i686:
Mozilla/5.0 (X11; Linux i686; rv:6.0a2) Gecko/20110525 Firefox/6.0a2

*Note: The option devtools.chrome.enabled is available. Marking this bug as Verified
Status: RESOLVED → VERIFIED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: