Closed Bug 646522 Opened 13 years ago Closed 13 years ago

buildbot: remove performance builders

Categories

(Tamarin Graveyard :: Tools, defect)

Product:
Tamarin Graveyard
Component:
Tools
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: cpeyer, Assigned: cpeyer)

Details

Attachments

(1 file, 1 obsolete file)

Updated patch
35.66 KB, patch
brbaker
: review+
Details | Diff | Splinter Review 
Performance machines are now in the internal sandbox.  Need to be removed from playercore buildbot.
Flags: flashplayer-bug-
Attached patch Remove perf builders and code (obsolete) — — Splinter Review 

        Attachment #523042 -
        Flags: review?(brbaker)

    
    

    
  
Comment on attachment 523042 [details] [diff] [review]
Remove perf builders and code

r- for a single missing item, assume r+ when addressed

1) need to update public_html/announce.html to remove the "performance" section since these builders are going to be removed.

        Attachment #523042 -
        Flags: review?(brbaker) → review-

    
    

    
  
Additional work items that I think need to be addressed:

- link/visibility to performance waterfall from the current waterfall view
- does the "buildbot watcher performance" service need to be running on playercore? If not uninstall the service and remove performance watcher config file
- should build/buildbot/*-performance/buildbot.tac be removed from source or updated?

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Updated patch
        — 
          — Splinter Review
      

    


  
- public_html/announce.html updated with a link to internal sandbox
- buildbot watcher perf service has been removed from playercore
- buildbot.tac files updated

        Attachment #523042 -
        Attachment is obsolete: true

        Attachment #523144 -
        Flags: review?(brbaker)

    
  

        Attachment #523144 -
        Attachment is patch: true

        Attachment #523144 -
        Attachment mime type: application/octet-stream → text/plain

    
    

    
  
Comment on attachment 523144 [details] [diff] [review]
Updated patch

r+ but please make sure to maintain and add the proper license header in the buildbot.tac files (patch shows header being removed and some of the new files do not have the header)

        Attachment #523144 -
        Flags: review?(brbaker) → review+

    
    

    
  
changeset: 6216:faef081aaecf
user:      Chris Peyer <cpeyer@adobe.com>
summary:   Bug 646522: remove performance builders (r=brbaker)

http://hg.mozilla.org/tamarin-redux/rev/faef081aaecf

    
  
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED

    
  
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: