646660 - fp::pc should work on frames outside the current context

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Brian Hackett [Laid off!]]

fp::pc currently only works on frames pushed by stack segments associated with the current context.  When recompiling in the JM+TI branch, we need to recompile and expand inline frames that can be on another context, but in the same compartment and StackSpace.

This requires fp::pc to walk all stack segments in the space.  Currently this would mean looking at every single frame in the thread, but it would be faster to just look at the start/end frames of each segment (since segments are continuous in memory).  This should be fixed too.

Comment 1

[Brian Hackett [Laid off!]]

Attachment: patch

Patch per the above.  This is a diff against JM, but will be the same on TM except for the Retcon.cpp change.  (Will push to JM before TM, to verify this fixes crashes seen on the JM tinderbox).

Comment 2

[Luke Wagner [:luke]]

Comment on attachment 523172 [details] [diff] [review]
patch

Great.  I forgot about StackSpace::contains :)

Comment 3

[Luke Wagner [:luke]]

Would you like me to land this?

Comment 4

[Brian Hackett [Laid off!]]

Sorry, been meaning to land this but got sidetracked.  There haven't been anymore problems with fp::pc on the JM branch, so feel free to land if you don't mind.  Thanks!

Comment 5

[Luke Wagner [:luke]]

http://hg.mozilla.org/tracemonkey/rev/3dc5d38ba870

Comment 6

[Chris Leary [:cdleary] (not checking bugmail)]

http://hg.mozilla.org/mozilla-central/rev/3dc5d38ba870