647198 - [ar] Adding twitter to Fennec search plugins

Status: RESOLVED FIXED

(Mozilla Localizations :: ar / Arabic, defect)

Description

[Anas Husseini [:linostar]]

We'd like to add twitter to fennec searchplugins (both on mobile-2.0 and mobile-browser). I took the chance to clean the old unneeded plugins (like yahoo, answers and wikipedia, but wasn't sure about google since it was removed from 1.9.2).

Comment 1

[Anas Husseini [:linostar]]

Attachment: patch adding twitter, and removing answers, yahoo and wikipedia

The patch is requested for both releases/l10n-mozilla-2.0/ar and l10n-central/ar.

Comment 2

[Staś Małolepszy :stas]

Comment on attachment 523557 [details] [diff] [review]
patch adding twitter, and removing answers, yahoo and wikipedia

Thanks for the patch.  Good call on removing the unused search plugins.  Adding Twitter is no problem as well, but I'm gonna r- this patch because I'd like to ask you to attach a new one -- without the twitter.xml file.  Putting "twitter" in list.txt is enough.  The xml file will be copied from en-US during the build process.  Thanks!

Comment 3

[Axel Hecht [:Pike]]

Also remove the google.xml one? You should only have wikipedia-ar.xml and list.txt in there, the other plugins are picked up from the en-US sources either way.

Comment 4

[Anas Husseini [:linostar]]

Attachment: patch v2

Comment 5

[Axel Hecht [:Pike]]

Comment on attachment 523564 [details] [diff] [review]
patch v2

r=me for l10n-central and l10n-mozilla-2.0.

Please land with a check-in comment referencing this bug and my review.

Notes: stas is OK to add the search plugin on 4.0.1.

Comment 6

[Anas Husseini [:linostar]]

Landed in

l10n-mozilla-2.0/ar:
http://hg.mozilla.org/releases/l10n-mozilla-2.0/ar/rev/321c8223aaea

l10n-central/ar:
http://hg.mozilla.org/l10n-central/ar/rev/c8e9ab5c3526