648178 - install-module.pl should check if a compiler is available, and fail with a clear error if one is not

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect)

Description

[:glob ✱]

install-module.pl should check if a compiler is available, and fail with a clear error if one is not.

while cpan itself will fail if a compiler is missing, the error message is not clear, and is hidden in a torrent of text.

Comment 1

[Max Kanat-Alexander]

Yes, however, it should only do this when you attempt to install something where the module of its dependencies need a compiler. It's very common to just install CGI.pm with install-module, and that does not need a compiler and shouldn't require one.

Comment 2

[Max Kanat-Alexander]

Attachment: v1

Okay, I changed my mind to improve the simplicity of implementation. install-module.pl now requires a compiler no matter what you try to do; it basically won't do anything at all without a compiler installed, now.

Comment 3

[Max Kanat-Alexander]

I only want to do this on trunk; I have no idea how requiring a compiler will affect the support burden. If it's a positive effect, we can backport it to 4.0 for 4.0.2.

Comment 4

[Frédéric Buclin]

Comment on attachment 526540 [details] [diff] [review]
v1

>=== removed file 'lib/README'

Why do you remove this file from the repo?

Comment 5

[Max Kanat-Alexander]

Attachment: v2

Was a simple mistake. (It happens if you do "rm -rf lib/*".)

Comment 6

[:glob ✱]

Comment on attachment 526620 [details] [diff] [review]
v2

looks good, works as advertised.  r=glob

Comment 7

[Max Kanat-Alexander]

Great, thanks! :-)

Comment 8

[Max Kanat-Alexander]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Install/CPAN.pm
modified Bugzilla/Install/Util.pm
modified template/en/default/setup/strings.txt.pl
Committed revision 7784.