Closed
Bug 648277
Opened 13 years ago
Closed 13 years ago
Flash fails to paint until mouse is moved
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(firefox5- fixed)
VERIFIED
FIXED
mozilla6
People
(Reporter: deleeuw+bugzilla, Assigned: roc)
References
()
Details
(Keywords: regression)
Attachments
(1 file)
852 bytes,
patch
|
tnikkel
:
review+
asa
:
approval-mozilla-aurora+
asa
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.2a1pre) Gecko/20110407 Firefox/4.2a1pre Build Identifier: When I on the attached URL display a Flash movie by clicking on "Teckenspråk" it doesn't show until I move the mouse on the place where it should be. I have confirmed that it is an issue with IPC. I have disabled IPC and then it works as it should. It also works in 3.6. It also works in Chrome 10. I also have a colleague that gets the same problem on her Firefox 4 on Windows 7. Reproducible: Always Steps to Reproduce: 1. Load the URL in this bug 2. Press "Teckenspråk" 3. A white space opens up, in that white space, move the mouse a bit Actual Results: Flash not painting itself. Expected Results: Flash painting itself.
Comment 1•13 years ago
|
||
Confirming with build: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0) Gecko/20100101 Firefox/4.0
Comment 2•13 years ago
|
||
I can reproduce on Fedora 12.
Status: UNCONFIRMED → NEW
Component: IPC → Plug-ins
Ever confirmed: true
OS: Windows 7 → All
QA Contact: ipc → plugins
Reporter | ||
Comment 3•13 years ago
|
||
My report may have been a bit confusing: Steps to Reproduce: 1. Load the URL in this bug 2. Press "Teckenspråk" 3. A white space opens up, where a flash should be Actual Results: Flash not painting itself. Expected Results: Flash painting itself. To repaint the flash move the mouse a bit.
Comment 4•13 years ago
|
||
Last good nightly: 2011-01-13 First bad nightly: 2011-01-14 Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=54184cfa6f0e&tochange=9f412256da4c against Flash 10.3.180.65/WinXP. => Fallout of Bug 605618?
Comment 5•13 years ago
|
||
I suspect bug 605618 or bug 619176. stechz, romaxa, thoughts?
Comment 6•13 years ago
|
||
I know little about Flash. Does Flash use nsGfxScrollFrames at all in the plugin process?
Comment 7•13 years ago
|
||
It does not.
Comment 8•13 years ago
|
||
Similar (or even the same) issue: bug 651999
Comment 10•13 years ago
|
||
No, sorry, I suspected it wasn't my bug and was a regression of 619176. The cross process code I touched shouldn't have anything to do with the Flash plugin process, I think. Chris, do you think bug 605618 could have caused this regression? If so, I can dig in though I may need some guidance!
Updated•13 years ago
|
Summary: Flash fails to paint until I hover on it → Flash fails to paint until mouse is moved
Reporter | ||
Comment 11•13 years ago
|
||
I think this should block fx5. Because it is a regression. I also think this is a bug of major importans, not normal importance. I'll leave that up to someone else to change though. I also think it affects a lot of pages out there. It wasn't very hard to find. And another seemingly related issue, bug 651999, has been found shortly thereafter. Potentially it affects any page with flash in it, if it has whatever triggers the lack of invalidation of the flash plugin.
tracking-firefox5:
--- → ?
Bisecting over the csets in comment 4 would be best.
Updated•13 years ago
|
Updated•13 years ago
|
Keywords: regressionwindow-wanted
The regression window is http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=54184cfa6f0e&tochange=9f412256da4c . We need that window narrowed down to the cset/bug that broke things.
Comment 14•13 years ago
|
||
Regression range: Works: http://hg.mozilla.org/mozilla-central/rev/70d10ef482f3 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b10pre) Gecko/20110113 Firefox/4.0b10pre ID:20110113045435 Fails: http://hg.mozilla.org/mozilla-central/rev/17fae822d2d7 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b10pre) Gecko/20110112 Firefox/4.0b10pre ID:20110113052706 Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=70d10ef482f3&tochange=17fae822d2d7 And In local build, Regression #1 is triggered by b9029c71a63a, build from b9029c71a63a: fails build from 08d4fcb4ebbf: works Regressed by: b9029c71a63a Oleg Romashin — Bug 619176 - Plugins get Visible state every time when scrolling (:BuildLayer always make them visible). r=roc a=approval2.0 #1. After clicking the button, unless the mouse pointer is moved, it does not play back the movie. And this is as same as regression #1 of Bug 647139 Comment 3 This does not happen regression #2 of Bug 647139 Comment 3, because of no auto-play.
Updated•13 years ago
|
Assignee: nobody → romaxa
Updated•13 years ago
|
Blocks: 619176
Keywords: regressionwindow-wanted
Comment 16•13 years ago
|
||
Discussed in triage - not a regression from 4.0 so not tracking for 5. This should get looked at by Roc since he reviewed the original patch and this could be nom'ed for approval if the risk is low, alternately land on m-c for 6.
Assignee: romaxa → roc
Comment 17•13 years ago
|
||
(In reply to comment #16) > Discussed in triage - not a regression from 4.0 so not tracking for 5. Correct, but this is a serious regression from Firefox 3.6 that made it into Firefox 4. I find this reasoning a bit weak.
Comment 18•13 years ago
|
||
José, I think you're just slightly confused about what "tracked" means. Please feel free to mail me privately if you want to talk about this.
Assignee | ||
Comment 19•13 years ago
|
||
I'll work on a testcase for this as well.
Attachment #531250 -
Flags: review?(tnikkel)
Comment 20•13 years ago
|
||
Comment on attachment 531250 [details] [diff] [review] fix Ah, so the desired effect of that RequestUpdatePluginGeometry call is that nsObjectFrame::ComputeWidgetGeometry gets called, not the ConfigureChildren on the parent widget (which makes no sense since this is a windowless plugin).
Attachment #531250 -
Flags: review?(tnikkel) → review+
Comment 22•13 years ago
|
||
Pushed: http://hg.mozilla.org/mozilla-central/rev/9cfa7843408b
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing]
Target Milestone: --- → mozilla6
Assignee | ||
Updated•13 years ago
|
Flags: in-testsuite?
Reporter | ||
Comment 25•13 years ago
|
||
I don't see the problem anymore on trunk.
Status: RESOLVED → VERIFIED
Assignee | ||
Comment 26•13 years ago
|
||
Comment on attachment 531250 [details] [diff] [review] fix Requesting Aurora approval. This is a pretty bad regression in FF4, we should fix it as soon as possible. The patch is very safe.
Attachment #531250 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 27•13 years ago
|
||
I tried to write a test, but I can't come up with a testcase that passes with the patch and fails without the patch :-(.
Updated•13 years ago
|
Attachment #531250 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Updated•13 years ago
|
Whiteboard: [needs landing]
Comment 29•13 years ago
|
||
(In reply to comment #27) > I tried to write a test, but I can't come up with a testcase that passes > with the patch and fails without the patch :-(. Robert, what kind of testcase do you need (if it's still needed)? Manual or automatic? Maybe the one in the URL field of the duplicated bug 658008 can be used as inspiration. Or maybe even ask the reporter of that bug if he can help to adapt that testcase to your requirements.
Assignee | ||
Comment 30•13 years ago
|
||
Automatic. I have a manual testcase that works fine, I just haven't found a way to reliably automate it using our test frameworks.
Assignee | ||
Comment 31•13 years ago
|
||
http://hg.mozilla.org/releases/mozilla-aurora/rev/13f156313874
Whiteboard: [needs landing]
Assignee | ||
Comment 32•13 years ago
|
||
Comment on attachment 531250 [details] [diff] [review] fix Requesting Aurora approval. This is a pretty bad regression in FF4, we should fix it as soon as possible. The patch is very safe.
Attachment #531250 -
Flags: approval-mozilla-beta?
Comment 33•13 years ago
|
||
Comment on attachment 531250 [details] [diff] [review] fix please get this landed on Aurora and Beta ASAP. Thanks.
Attachment #531250 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Assignee | ||
Updated•13 years ago
|
Whiteboard: [needs landing]
Assignee | ||
Comment 34•13 years ago
|
||
http://hg.mozilla.org/releases/mozilla-beta/rev/0f05ac394e87
status-firefox5:
--- → fixed
Whiteboard: [needs landing]
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•