648371 - Convert async tests to use run_next_test helper

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Comment 1

[Philipp von Weitershausen [:philikon]]

Attachment: v1

Get rid of Utils.asyncChain in all sync tests apart from test_resource_async and test_resource_ua. Both tests should be converted eventually, but would require some more involved refactoring. Will file follow up for those, if rnewman agrees with that approach.

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 526767 [details] [diff] [review]
v1

As discussed on IRC:

> -Engines.register(BookmarksEngine);
> +//Engines.register(BookmarksEngine);

I'm not sure I like this approach:

> +add_test(function cleanup() {
> +  _("Clean up.");
> +  Svc.History.removeAllPages();
> +  run_next_test();
> +});

but I see why it's done (given the splitting of some tests into independent mini-tests).

I would prefer for the underlying mechanism to support per-suite and per-test setup and teardown slots, so this cleanup function wouldn't have to pretend to be a test, but perhaps that's an rfe for another day.

Otherwise, this looks good. Going to run tests locally then flip the flag.

Comment 3

[Philipp von Weitershausen [:philikon]]

http://hg.mozilla.org/services/services-central/rev/f0cbe8de70c9

Filed bug 650941 for the two left overs.

Comment 4

[Philipp von Weitershausen [:philikon]]

http://hg.mozilla.org/mozilla-central/rev/f0cbe8de70c9