Closed Bug 648654 Opened 13 years ago Closed 13 years ago

Add user-visible pref for Do Not Track

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Firefox 5

People

(Reporter: madhava, Assigned: kbrosnan)

References

Details

(4 keywords, Whiteboard: [has patch][has review][strings][metro-mvp])

Attachments

(2 files, 1 obsolete file)

A patch [checked-in]
2.88 KB, patch
mbrubeck
: review+
Details | Diff | Splinter Review
screenshot
75.11 KB, image/png
Details 
Let's put it in the Privacy & Security section, right before Clear private data.

text of pref:

Tell sites not to track me    [YES|NO]
Assignee: nobody → kbrosnan
Attached patch Add the pref (obsolete) — — Splinter Review 

        Attachment #524804 -
        Flags: review?(mbrubeck)

    
    

    
  
Drive-by: Madhava wanted the new pref "right before Clear private data". The patch has it right before "Remember passwords"

    
    

    
  
Otherwise, looks good to me. Thanks Kevin!

    
    

    
  


  

        Attachment #524804 -
        Attachment is obsolete: true

        Attachment #524804 -
        Flags: review?(mbrubeck)

        Attachment #524914 -
        Flags: review?(mbrubeck)

        Attachment #524914 -
        Flags: review?(mbrubeck) → review+

    
    

    
  

      
      
      
      

        Attached image
          
        screenshot
        — 
      

    


  
Madhava, can you review this proposed UI and new string?

        Attachment #525087 -
        Flags: ui-review?(madhava)

    
    

    
  
Comment on attachment 525087 [details]
screenshot

Oops, obviously I did not look at the comment history.

        Attachment #525087 -
        Flags: ui-review?(madhava)
Keywords: mobile, 
          
            pp, 
          
            privacy
OS: Android → All
Hardware: x86 → All
Whiteboard: [has patch][has review]
Whiteboard: [has patch][has review] → [has patch][has review][strings]

    
  
Keywords: checkin-needed

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/7cf73914be2a
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED

    
    

    
  
VERIFIED FIXED on: 

Build Id: Mozilla /5.0 (Android;Linux armv7l;rv:2.2a1pre) Gecko/20110412 Firefox/4.2a1pre Fennec /4.1a1pre 

Device: HTC Desire Z (Android 2.2)
Status: RESOLVED → VERIFIED
Flags: in-litmus?(astoica)
Flags: in-litmus?(astoica) → in-litmus?

        Attachment #524914 -
        Attachment description: A patch → A patch [checked-in]
Target Milestone: --- → Firefox 5
Depends on: DNT

    
  
Keywords: feature
Whiteboard: [has patch][has review][strings] → [has patch][has review][strings][metro-mvp]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: