648876 - Remove superfluous $(OS_ARCH) filter-outs from js/src/Makefile.in (bug 647389 follow-up)

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Ed Morley [:emorley]]

Follow-up to bug 647389, which removed all instances of |WINCE| from js/src/Makefile.in

This left a few of:

> ifeq (,$(filter-out XXXXX,$(OS_ARCH)))
and
> ifneq (,$(filter-out XXXXX,$(OS_ARCH)))

...whereby XXXXX was just one platform; and as such is equivalent to:

> ifeq ($(OS_ARCH),XXXXX)
and
> ifneq ($(OS_ARCH),XXXXX)

Comment 1

[Ed Morley [:emorley]]

Attachment: Patch v1 (based on TM rev 4ace629bb676)

Comment 2

[Jason Orendorff [:jorendorff]]

Shifting the review to jimb, who actually knows this language ;)

Comment 3

[Ed Morley [:emorley]]

Sorry, just used your r+ in bug 647389 as inspiration for who to pick! :-)

Is there a list somewhere of who is best to ask for reviews? (Other than just looking at hg log)

Comment 4

[Jim Blandy :jimb]

(In reply to comment #2)
> Shifting the review to jimb, who actually knows this language ;)

Oh, it's a very pleasant little stringy language! You'd *love* it!

Comment 5

[Jim Blandy :jimb]

Comment on attachment 524969 [details] [diff] [review]
Patch v1 (based on TM rev 4ace629bb676)

Thanks for the cleanup!

Comment 6

[Ed Morley [:emorley]]

(In reply to comment #5)
> Thanks for the cleanup!

No problem! Thanks for the speedy review :-)

Comment 7

[Paul Biggar]

(In reply to comment #3)
> Sorry, just used your r+ in bug 647389 as inspiration for who to pick! :-)
> 
> Is there a list somewhere of who is best to ask for reviews? (Other than just
> looking at hg log)

hg log and blame work best, but there is also this list: https://wiki.mozilla.org/JavaScript:Hackers

Comment 8

[Ed Morley [:emorley]]

(In reply to comment #7)
> hg log and blame work best, but there is also this list:
> https://wiki.mozilla.org/JavaScript:Hackers

Great, thanks!

Comment 9

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/58323bbaaa67

Comment 10

[Paul Biggar]

(In reply to comment #9)
> http://hg.mozilla.org/mozilla-central/rev/58323bbaaa67

Just an FYI - changes in js/src/ should go into the tracemonkey tree. This should be fine this time though, no need for a backout or anything.

Comment 11

[(no longer active)]

(In reply to comment #10)
> (In reply to comment #9)
> > http://hg.mozilla.org/mozilla-central/rev/58323bbaaa67
> 
> Just an FYI - changes in js/src/ should go into the tracemonkey tree. This
> should be fine this time though, no need for a backout or anything.

Sorry, I usually pay attention to not land js checkin-needed stuff, this one got through my list somehow...

Comment 12

[Ed Morley [:emorley]]

http://mxr.mozilla.org/mozilla-central/search?string=%28%2C%24%28filter-out+WINNT&find=%2Fjs%2Fsrc%2FMakefile.in&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central
...returns 0 results.

-> Verified.