Closed
Bug 648882
Opened 13 years ago
Closed 13 years ago
TabPriorityQueue updates tabItems when UI is busy
Categories
(Firefox Graveyard :: Panorama, defect)
Firefox Graveyard
Panorama
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 6
People
(Reporter: ttaubert, Assigned: ttaubert)
Details
Attachments
(1 file, 9 obsolete files)
2.74 KB,
patch
|
Details | Diff | Splinter Review |
The condition is now: if (this.isPaintingPaused() || !UI.isIdle) and should be: if (this.isPaintingPaused() || !UI.isIdle()) We should add a test to verify that no tabItem updates are done when resizing or moving items.
Assignee | ||
Updated•13 years ago
|
Summary: TabPriorityQueue updates when UI is busy → TabPriorityQueue updates tabItems when UI is busy
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #524979 -
Flags: feedback?(raymond)
Comment 2•13 years ago
|
||
Comment on attachment 524979 [details] [diff] [review] patch v1 + EventUtils.synthesizeMouse(container, 5, 5, {type: "mousedown"}, cw); + EventUtils.synthesizeMouse(container, 40, 20, {type: "mousemove"}, cw); + EventUtils.synthesizeMouse(container, 20, 20, {type: "mouseup"}, cw); The above repeats twice, might be good to write a helper function. f+
Attachment #524979 -
Flags: feedback?(raymond) → feedback+
Assignee | ||
Comment 3•13 years ago
|
||
Comment on attachment 524979 [details] [diff] [review] patch v1 Passed try: http://tbpl.mozilla.org/?tree=MozillaTry&pusher=tim.taubert@gmx.de&rev=20df3dc1f2fd
Assignee | ||
Comment 4•13 years ago
|
||
Attachment #524979 -
Attachment is obsolete: true
Attachment #525095 -
Flags: review?(ian)
Comment 5•13 years ago
|
||
Comment on attachment 525095 [details] [diff] [review] patch v2 That's a pretty slick test :)
Attachment #525095 -
Flags: review?(ian) → review+
Assignee | ||
Comment 6•13 years ago
|
||
Attachment #525095 -
Attachment is obsolete: true
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 7•13 years ago
|
||
Attachment #525923 -
Attachment is obsolete: true
Comment 8•13 years ago
|
||
http://hg.mozilla.org/projects/cedar/rev/b1fc69fab8b2
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: fixed-in-cedar
Target Milestone: --- → Firefox 6
Comment 9•13 years ago
|
||
The test added by this patch went orange: <http://tinderbox.mozilla.org/showlog.cgi?log=Cedar/1302807869.1302809327.10302.gz> so I backed it out: <http://hg.mozilla.org/projects/cedar/rev/53339e6932c3>
Whiteboard: fixed-in-cedar
Assignee | ||
Comment 10•13 years ago
|
||
Added another test for another issue fixed with this patch.
Attachment #525983 -
Attachment is obsolete: true
Attachment #526118 -
Flags: feedback?(raymond)
Comment 11•13 years ago
|
||
Comment on attachment 526118 [details] [diff] [review] patch v3 Looks good. Can we merge two tests file into one?
Attachment #526118 -
Flags: feedback?(raymond) → feedback+
Assignee | ||
Comment 12•13 years ago
|
||
(In reply to comment #11) > Looks good. Can we merge two tests file into one? Of course, don't know why I split them :)
Attachment #526118 -
Attachment is obsolete: true
Attachment #526179 -
Flags: review?(ian)
Assignee | ||
Comment 13•13 years ago
|
||
Comment on attachment 526179 [details] [diff] [review] patch v4 Failed on OSX opt: http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTry/1302848610.1302854494.9835.gz Investigating.
Assignee | ||
Comment 14•13 years ago
|
||
Attachment #526179 -
Attachment is obsolete: true
Attachment #526179 -
Flags: review?(ian)
Attachment #526333 -
Flags: review?(ian)
Assignee | ||
Comment 15•13 years ago
|
||
Comment on attachment 526333 [details] [diff] [review] patch v5 Passed try: http://tbpl.mozilla.org/?tree=MozillaTry&pusher=tim.taubert@gmx.de&rev=c04433b1ca25
Comment 16•13 years ago
|
||
Comment on attachment 526333 [details] [diff] [review] patch v5 Looks good.
Attachment #526333 -
Flags: review?(ian) → review+
Assignee | ||
Comment 17•13 years ago
|
||
Attachment #526333 -
Attachment is obsolete: true
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Updated•13 years ago
|
Keywords: checkin-needed
Whiteboard: [fixed in cedar]
Comment 18•13 years ago
|
||
Pushed: http://hg.mozilla.org/mozilla-central/rev/028fc2dcb854
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in cedar]
Comment 19•13 years ago
|
||
The test if failing: http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1303305581.1303307355.28425.gz I've made a backout: http://hg.mozilla.org/mozilla-central/rev/347ea6f52589
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 20•13 years ago
|
||
You should not use setTimeout(func, value) with value>0 if you do not want your test to be flaky.
Assignee | ||
Comment 21•13 years ago
|
||
(In reply to comment #20) > You should not use setTimeout(func, value) with value>0 if you do not want your > test to be flaky. Good to know, removed.
Attachment #527023 -
Attachment is obsolete: true
Attachment #527343 -
Flags: feedback?(raymond)
Comment 22•13 years ago
|
||
Comment on attachment 527343 [details] [diff] [review] patch v6 (without setTimeout) Looks good
Attachment #527343 -
Flags: feedback?(raymond) → feedback+
Assignee | ||
Updated•13 years ago
|
Attachment #527343 -
Flags: review?(ian)
Assignee | ||
Comment 23•13 years ago
|
||
Comment on attachment 527343 [details] [diff] [review] patch v6 (without setTimeout) Passed try: http://tbpl.mozilla.org/?tree=MozillaTry&pusher=tim.taubert@gmx.de&rev=43fe3397f7a0
Comment 24•13 years ago
|
||
Comment on attachment 527343 [details] [diff] [review] patch v6 (without setTimeout) Review of attachment 527343 [details] [diff] [review]: Very clever :)
Attachment #527343 -
Flags: review?(ian) → review+
Assignee | ||
Comment 25•13 years ago
|
||
Attachment #527343 -
Attachment is obsolete: true
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Updated•13 years ago
|
Keywords: checkin-needed
Whiteboard: [fixed in cedar]
Comment 26•13 years ago
|
||
Pushed: http://hg.mozilla.org/mozilla-central/rev/4e7e81ad7525 Thank you for fixing the random orange Tim :)
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in cedar]
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•