Closed Bug 649132 Opened 13 years ago Closed 13 years ago

fix slavealloc dashboard

Categories

(Release Engineering :: General, defect)

Product:
Release Engineering
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: dustin, Assigned: dustin)

Details

(Whiteboard: [slavealloc])

Attachments

(1 file)

m649132-tools-r1.patch
781 bytes, patch
bear
: review+
Details | Diff | Splinter Review 
I broke the dashboard view a while back.  The fix is straightforward.

        Attachment #525171 -
        Flags: review?(bear)

    
    

    
  
Comment on attachment 525171 [details] [diff] [review]
m649132-tools-r1.patch

I need to relearn (or maybe this will morph to a more normal web frontend ;) ) how twisted nevow works since I missed this on the first review

        Attachment #525171 -
        Flags: review?(bear) → review+

    
    

    
  
It's not nevow - just Twisted Web2.  This fix was entirely in JS, as was the breakage -- somehow I refactored three elements in a list and not the fourth.  It may have been a merge error.

At any rate, the JS frontend and the Python backend are almost completely unrelated to one another, so you should be able to read through them separately.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: