Closed
Bug 649194
Opened 13 years ago
Closed 12 years ago
Abort when the cache IO thread can't be created
Categories
(Core :: Networking: Cache, defect)
Core
Networking: Cache
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: michal, Assigned: michal)
Details
Attachments
(1 file)
773 bytes,
patch
|
briansmith
:
review+
|
Details | Diff | Splinter Review |
Right now we don't fail to initialize the cache service when initialization of a cache IO thread fails (http://hg.mozilla.org/mozilla-central/annotate/94874a2f3bb3/netwerk/cache/nsCacheService.cpp#l1031). But we do try to dispatch events to this thread with no fallback in case the thread is not available. E.g. http://hg.mozilla.org/mozilla-central/annotate/94874a2f3bb3/netwerk/cache/nsCacheService.cpp#l732 I can't see a reason why creating a new thread should fail unless the process is experiencing some fatal problem, so IMO it makes sense to fail to initialize the cache service.
Comment 1•13 years ago
|
||
I believe we should just NS_RUNTIMEABORT...
Comment 2•13 years ago
|
||
> I believe we should just NS_RUNTIMEABORT...
+1
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #609517 -
Flags: review?(bsmith)
Assignee | ||
Updated•12 years ago
|
Summary: Handle correctly case when the cache IO thread can't be created → Abort when the cache IO thread can't be created
Comment 4•12 years ago
|
||
Comment on attachment 609517 [details] [diff] [review] fix Review of attachment 609517 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.
Attachment #609517 -
Flags: review?(bsmith) → review+
Assignee | ||
Comment 5•12 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/c5d6aa6be62c
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c5d6aa6be62c
Target Milestone: --- → mozilla14
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•