649223 - Reftest for bug 366207 wastes two seconds, needlessly

Status: RESOLVED FIXED

(Core :: XBL, defect)

Description

[(no longer active)]

See the discussion in bug 366207 comment 10 onwards.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 525291 [details] [diff] [review]
Patch (v1)

r=me

Comment 3

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/2e8556ead460

Comment 4

[Martijn Wargers (dead)]

So this was tested on an older build to make sure it still triggered the assertion?

Comment 5

[(no longer active)]

(In reply to comment #4)
> So this was tested on an older build to make sure it still triggered the
> assertion?

No.  As mentioned earlier, the test didn't really test anything useful in the first place, so there's no point in testing it on an earlier build.

Comment 6

[Martijn Wargers (dead)]

Oh, why is the test there in the first place?

Comment 7

[(no longer active)]

(In reply to comment #6)
> Oh, why is the test there in the first place?

To catch other possible future failures.  Tests are useful for other purposes behind regression testing the original change they're added for.