649367 - "nightly is up to date" does not have enough contrast against the new about window dark backgrounds

Status: VERIFIED FIXED

(Firefox :: General, defect)

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Maybe needs an outline/background like the alt-toggled menu bar on Win7 with Aero?

Comment 2

[Marco Bonardo [:mak]]

A text-shadow could also work, fwiw this is not a text that needs high readability.
Btw, I think a better bug to block against is probably bug 648362 that added the new dark backgrounds, the icons by themselves don't cause issues.

Comment 3

[:Margaret Leibovic]

Attachment: patch to make text white

This patch just makes the text white. I don't think we need to be doing anything complicated here, just ensuring it's readable is a sufficient solution, especially since this only affects nightly/aurora builds.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 525543 [details] [diff] [review]
patch to make text white

Should someone ui-review this? I'm OK with it visually, which is reason for worry.

Comment 5

[Alex Limi (:limi) — Firefox UX Team]

LGTM.

Comment 6

[Mounir Lamouri (:mounir)]

Pushed in cedar:
http://hg.mozilla.org/projects/cedar/rev/8794c0df7997

Comment 7

[Mounir Lamouri (:mounir)]

Pushed in m-c:
http://hg.mozilla.org/mozilla-central/rev/8794c0df7997

Comment 8

[AndreiD[QA]]

Verified on

Win7: 
Mozilla/5.0 (Windows NT 6.1; rv:6.0a1) Gecko/20110421 Firefox/6.0a1

Win XP:
Mozilla/5.0 (Windows NT 5.1; rv:6.0a1) Gecko/20110421 Firefox/6.0a1 

Linux:
Mozilla/5.0 (X11; Linux i686; rv:6.0a1) Gecko/20110421 Firefox/6.0a1

Mac 10.6:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:6.0a1) Gecko/20110421
Firefox/6.0a1