Closed
Bug 649491
Opened 13 years ago
Closed 13 years ago
rm JSFRAME_ASSIGNING
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: luke, Assigned: luke)
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
16.68 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
JSFRAME_ASSIGNING is only used to tell js_InferFlags we are assigning. This can be done more simply the way everywhere else does it: with JSAutoResolveFlags. This came up in the context of bug 645901 when I was looking for places where we unnecessarily twiddle frame flags (thereby requiring frame deoptimization).
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #525512 -
Flags: review?(dvander)
Comment 2•13 years ago
|
||
Comment on attachment 525512 [details] [diff] [review] do it >+ uint32 opFormat = cs->format; Nit: format is the canonical name elsewhere. >+ uint32 setPropFlags = JOF_MODE(opFormat) == JOF_NAME Nit: we follow K&R and parenthesize lower-than-unary-precedence ?: conditions. JSFRAME_flagls: one down, 21 to go! :-P /be
Assignee | ||
Comment 3•13 years ago
|
||
Ah, good to know. I doubt the flags will be dying any time soon (bug 645901 will avoid even storing them!), but the thing I'd really like to see go are these resolve flags. Unfortunately, it seems like DOM global window quirks really want them...
Comment on attachment 525512 [details] [diff] [review] do it nice
Attachment #525512 -
Flags: review?(dvander) → review+
Assignee | ||
Updated•13 years ago
|
Whiteboard: fi
Assignee | ||
Comment 5•13 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/45d3b3a77929
Whiteboard: fi → fiixed-in-tracemonkey
Assignee | ||
Comment 6•13 years ago
|
||
Srsly, fixed-in-tracemonkey.
Whiteboard: fiixed-in-tracemonkey → fixed-in-tracemonkey
Comment 7•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/45d3b3a77929
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•