Closed
Bug 649531
Opened 13 years ago
Closed 13 years ago
tidy up this-computation logic a bit, add some asserts (b/c #jsapi told me to)
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: luke, Assigned: luke)
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file, 1 obsolete file)
|
20.88 KB,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
This patch factors out some prep work for bug 644074. 0. Inline ComputeGlobalThis into its only caller 1. Split CallArgs into CallReceiver and CallArgs to capture/remove the uses of 'vp' where we don't have/care about argv. 2. Assert call.callee() isn't used after call.rval() 3. Change JSStackFrame::computeThis into a free function since isn't a simple accessor/mutator of a stack frame; its an effectful interpreter operation akin to ComputeImplicitThis/GetPrimitiveThis/BoxNonStrictThis. Put it next to these functions. 4. Reunite GetPrimitiveThis and details::PrimitiveBehavior
Attachment #525564 -
Flags: review?(jwalden+bmo)
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #525564 -
Attachment is obsolete: true
Attachment #525564 -
Flags: review?(jwalden+bmo)
Attachment #526092 -
Flags: review?(jwalden+bmo)
|
||
Updated•13 years ago
|
Attachment #526092 -
Flags: review?(jwalden+bmo) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/e06d53aec568
Whiteboard: fixed-in-tracemonkey
|
||
Comment 3•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/e06d53aec568
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•