649583 - Panning regression on google reader in 2011-04-12 nightly

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Panning/Zooming, defect)

Description

[Mike Hommey [:glandium]]

Here is my setup:
- Go on http://google.com/reader/i
- Subscribe to http://feeds.feedburner.com/DilbertDailyStrip
- Select any of the past comic
- Click zoom in

Up until 2011-04-11 nightly (double checked with ftp://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/2011-04-11-05-mozilla-central-android-r7/), one could scroll the zoomed comic strip by dragging it.

Since 2011-04-12 nightly (double checked with ftp://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/2011-04-12-04-mozilla-central-android-r7/), dragging the zoomed comic strip brings the right panel and doesn't scroll the comic strip.

Comment 1

[Mike Hommey [:glandium]]

The tinderbox build corresponding to http://hg.mozilla.org/mozilla-central/rev/b48ebf9695bb already has this problem. Unfortunately, there's no older tinderbox build on ftp.mozilla.org

Comment 2

[Mike Hommey [:glandium]]

This might be a regression from bug 639179

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Probably iframes in general. See bug 649585 too:

Steps to reproduce: 
1. Go to html code tutorial:
http://www.htmlcodetutorial.com/frames/_IFRAME.html
2. Click into the iframe
3. Try to scroll within the iframe

Comment 5

[Mike Hommey [:glandium]]

So, I did a try build off that failing nightly, with bug 639179 backed out, and... still the same problem.
http://hg.mozilla.org/try/rev/d1c92a3c2989
https://ftp.mozilla.org/pub/mozilla.org/firefox/tryserver-builds/[e-mail]-d1c92a3c2989/try-mob-andrd-r7-bld/

Comment 6

[Benjamin Smedberg]

We'd like to get a solution for this on Aurora within a week, either by backout or fix.

Comment 7

[Mike Hommey [:glandium]]

A few data points, since I have them:
The nightly that I tested was working is 09b605eb3e0d
The nightly that I tested was not working is 48d6abe0a436
The oldest tinderbox build that I tested was not working is b48ebf9695bb
The latest aurora build also doesn't work. (wasn't sure of the merge/fork point)

Comment 8

[Mike Hommey [:glandium]]

Grah, looks like firefox decided I wanted to reset tracking-firefox5 :(

Comment 9

[Benjamin Stover (:stechz)]

Attachment: PAnning regression on google reader in 2011-04-12 nightly

Comment 10

[Benjamin Stover (:stechz)]

OK, somehow I missed a merge conflict and one of the files did not get patched.

Comment 11

[Benjamin Stover (:stechz)]

Comment on attachment 525795 [details] [diff] [review]
PAnning regression on google reader in 2011-04-12 nightly

(already reviewed)

Comment 12

[Benjamin Stover (:stechz)]

Attachment: Panning regression on google reader in 2011-04-12 nightly

Comment 13

[Benjamin Stover (:stechz)]

Pushed http://hg.mozilla.org/mozilla-central/rev/193ec7c89ad5

Comment 14

[Matt Brubeck (:mbrubeck)]

This was a regression caused by an error on checkin of bug 642246.  This should go to Aurora.

Comment 15

[Timothy Nikkel (:tnikkel)]

Did this get review from someone besides the patch author?

Comment 16

[Benjamin Stover (:stechz)]

Yes, roc. See comments 10 and 11.

Comment 18

[Andreea Pod]

Mozilla /5.0 (Android;Linux armv7l;rv:5.0a2) Gecko/20110414 Firefox/5.0a2 Fennec/5.0a2 
Device: LG Optimus 2X (Android 2.2)

I still can't pan the iframe from http://www.htmlcodetutorial.com/frames/_IFRAME.html. Reopening the bug.

Comment 19

[Mike Hommey [:glandium]]

My Dilbert test case works on the 20110414 6.0a1 nightly.

Comment 20

[Mike Hommey [:glandium]]

Your test case is also fixed (no surprise, really). It probably hasn't landed on Aurora yet, though.

Comment 21

[Johnny Stenback (:jst)]

Not approving this yet, we'd like to get more confidence that this doesn't hurt desktop. Can we get layout people to vouch for that, or some other feedback here?

Comment 22

[Benjamin Stover (:stechz)]

Comment on attachment 525797 [details] [diff] [review]
Panning regression on google reader in 2011-04-12 nightly

We definitely want this patch for Fennec. Roc, could you weigh in?

As a reminder, Roc approved the original patch, which landed but did not have the needed changes to FrameLayerBuilder.cpp. These changes allow for empty layers to be sent across process instead of culled. For Firefox, there should be no other impact, because Firefox will never have any LAYER_ACTIVE_EMPTY display items.

Comment 23

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 525797 [details] [diff] [review]
Panning regression on google reader in 2011-04-12 nightly

Right, we can be very confident this does not affect desktop.

Comment 24

[Aakash Desai [:aakashd]]

verified FIXED On builds:
Mozilla/5.0 (Android; Linux armv7l; rv:6.0a1) Gecko/20110421 Firefox/6.0a1 Fennec/6.0a1 ID:20110421043148

Comment 25

[Matt Brubeck (:mbrubeck)]

Pushed to Aurora:
http://hg.mozilla.org/mozilla-aurora/rev/8369b648ab94

Comment 26

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Verified on Aurora Branch:
Mozilla/5.0 (Android; Linux armv71; rv5.0a2) Gecko/20110509 Firefox/5.0a2 Fennec/5.0a2
Device: Thunderbolt
OS: Android 2.2