649685 - Setting layers.prefer-opengl to true causes screen to be flipped horizontally upside down

Status: VERIFIED FIXED

(Core :: Graphics, defect)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:6.0a1) Gecko/20110412 Firefox/6.0a1
Build Identifier: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:6.0a1) Gecko/20110412 Firefox/6.0a1

 

Reproducible: Always

Steps to Reproduce:
1. Set layers.prefer-opengl to true

Comment 1

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: screenshot

Comment 2

[Matt Woodrow (:mattwoodrow)]

Attachment: Stop flipping when blitting the backbuffer to the window

This should fix the issue. Don't have a machine to test it on here, will try when I get home if nobody beats me to it.

Comment 3

[Joe Drew (not getting mail)]

Comment on attachment 526102 [details] [diff] [review]
Stop flipping when blitting the backbuffer to the window

This should be pretty easy to test, correct? Or would it already be caught in our tests?

Comment 4

[Pedro Arvela]

Attachment: Screenshot in Linux

I noticed this bug is marked for Windows, but I can reproduce it in Linux. The attached screenshot is from Ubuntu 10.10, with proprietary ATI driver fglrx 8.780 from the Ubuntu repositories. Graphics card is an ATI Radeon HD 2400 Pro. It is Firefox 6 from the Nightly branch, build from 2011-05-08.

Comment 5

[Benoit Jacob [:bjacob] (mostly away)]

Yes, I've heard other people reporting it on linux too.

Comment 6

[Matt Woodrow (:mattwoodrow)]

(In reply to comment #3)
> 
> This should be pretty easy to test, correct? Or would it already be caught
> in our tests?

I can't think of any easy way, no.

It only affects the single buffered configuration (WGL and GLX with radeon), which we don't have test machines for.

It also only flips on the final blit to the window, so both the test and reference should always still match.

Comment 7

[Matt Woodrow (:mattwoodrow)]

http://hg.mozilla.org/mozilla-central/rev/f44b71c6c327

Comment 8

[James]

This bug is able to be reproduced in the current release version (Firefox 5.0). Did the patch not make it in time? :(

Comment 9

[Boris Zbarsky [:bzbarsky]]

Yes.  This was checked in a month after Firefox 5 branched.

Comment 10

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

(In reply to comment #8)
> This bug is able to be reproduced in the current release version (Firefox
> 5.0). Did the patch not make it in time? :(

But still OpenGL rendering didn't work properly even in this bug is fixed. See bug #656565