649783 - Wizard setup calls Service.startOver… which now tries to delete server entries

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Richard Newman [:rnewman]]

Probably shouldn't do that. :)

Comment 1

[Richard Newman [:rnewman]]

Attachment: v1

Fix is to not delete unless we have a clusterURL.

Test augmented to match.

Comment 2

[Philipp von Weitershausen [:philikon]]

Comment on attachment 525833 [details] [diff] [review]
v1

>+    // Deletion doesn't make sense if we aren't set up yet!
>+    if (this.clusterURL != "") {

if (this.clusterURL) woulda worked too...

r=philikon

Comment 3

[Richard Newman [:rnewman]]

Pushed:

https://hg.mozilla.org/services/services-central/rev/fad52be02cdc

STR for QA:

* Use a profile without Sync set up.
* Enable Sync logging.
* Open "Set Up Sync" dialog.
* Click "Connect".
* Click "Cancel". Observe no errors about malformed URIs in the log. Instead, you'll see a statement like this:

  Skipping client data removal: no cluster URL.

Comment 4

[Tracy Walker [:tracy]]

verified in s-c builds of 1303795082

instead of malformed URI's error, now seeing:

1303835771043	Net.Resource	DEBUG	mesg: GET fail 304 https://setup.services.mozilla.com/d8ik
1303835771043	Net.Resource	DEBUG	GET fail 304 https://setup.services.mozilla.com/d8ik
1303835771738	Service.JPAKEClient	DEBUG	Aborting...
1303835771738	Service.JPAKEClient	DEBUG	Reporting failure to server.
1303835771738	Net.Resource	DEBUG	POST Length: 0
1303835771739	Service.Main	DEBUG	Skipping client data removal: no cluster URL.
1303835771739	Service.Main	INFO	Service reset.
1303835771740	Engine.Clients	DEBUG	Resetting clients last sync time

Comment 5

[Philipp von Weitershausen [:philikon]]

http://hg.mozilla.org/mozilla-central/rev/fad52be02cdc

Comment 6

[Tony Chung [:tchung]]

Verified fix on m-c: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:6.0a1) Gecko/20110427 Firefox/6.0a1

Comment 7

[Philipp von Weitershausen [:philikon]]

This was also landed on mozilla-beta (mozilla5) as part of bug 662181:

https://hg.mozilla.org/releases/mozilla-beta/rev/9d2108905529
https://hg.mozilla.org/releases/mozilla-beta/rev/065b5f7e37c1