650282 - Rename all things Tryserver/MozillaTry to just Try in order to have uniform naming from repo-name on down

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Chris AtLee [:catlee]]

Not sure how long this has been happening. It's breaking reporting of talos results for try:

FAIL: Graph server unreachable (5 attempts)
RETURN:send failed, graph server says:
RETURN:No branch_id for a branch_name 'MozillaTry' can be found
RETURN:  File "/data/www/graphs.mozilla.org/server/pyfomatic/collect.py", line 264, in handleRequest
RETURN:    metadata = MetaDataFromTalos(databaseCursor, databaseModule, inputStream)
RETURN:  File "/data/www/graphs.mozilla.org/server/pyfomatic/collect.py", line 59, in __init__
RETURN:    self.doDatabaseThings(databaseCursor)
RETURN:  File "/data/www/graphs.mozilla.org/server/pyfomatic/collect.py", line 109, in doDatabaseThings
RETURN:    raise DatabaseException("No branch_id for a branch_name '%s' can be found" % self.branch_name)

Comment 1

[Patrick McManus [:mcmanus]]

this blocks resolving 628561

Comment 2

[Patrick McManus [:mcmanus]]

is a fix for this still on the radar?

Comment 3

[Lukas Blakk [:lsblakk] use ?needinfo]

To make things like this less likely to happen, I've morphed this bug into a tracking bug where I'll document moving all things tryserver over to just try to match the repo name which is what all other branches do (or should).

Repo Name / Branch Name / Tinderbox tree name / Graphserver entry will all be just "Try"

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: data.sql patch for renaming Tryserver -> Try

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: renaming 'tryserver' to 'try' across the board

this will require at the very least, notice, and at most a small try downtime since it will change where the builds go to try-builds instead of tryserver-builds

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

the changes from bug 651513 caused some fallout.

http://tbpl.mozilla.org/?tree=MozillaTry&rev=15a61bf47863

Comment 8

[Chris AtLee [:catlee]]

Comment on attachment 527294 [details] [diff] [review]
renaming 'tryserver' to 'try' across the board

so far so good.

I think we need to rename the mozconfigs too?

Comment 9

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: renaming 'tryserver' to 'try' across the board v2 with mozconfigs

renamed tryserver mozconfigs to try

Comment 10

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: renaming 'tryserver' to 'try' across the board v2 with mozconfigs

and now, from the right dir.

Comment 11

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 527797 [details] [diff] [review]
renaming 'tryserver' to 'try' across the board v2 with mozconfigs

http://hg.mozilla.org/build/buildbot-configs/rev/af01d1e2040a

Comment 12

[Lukas Blakk [:lsblakk] use ?needinfo]

landed http://hg.mozilla.org/hgcustom/hghooks/rev/e3e66525453c and reopened bug 651027 to request a treeclosure hook update.

Comment 13

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: data.sql patch for renaming Tryserver -> Try

this one includes renaming the machines

Comment 14

[Lukas Blakk [:lsblakk] use ?needinfo]

landed a bustage fix renaming the mobile configs too: http://hg.mozilla.org/build/buildbot-configs/rev/82171f0757f7

Comment 15

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: try renaming buildbotcustom changes

Comment 16

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: try renaming in post_upload.py

Comment 17

[Aki Sasaki (not active)]

Comment on attachment 527828 [details] [diff] [review]
try renaming in post_upload.py

As mentioned in IRC, we need to fix the NFS mounts, create the upload try-builds dir, and fix the crontabs on stage.

Comment 18

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 527827 [details] [diff] [review]
try renaming buildbotcustom changes

http://hg.mozilla.org/build/buildbotcustom/rev/c5d45a4431bd

Comment 19

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 527828 [details] [diff] [review]
try renaming in post_upload.py

http://hg.mozilla.org/build/tools/rev/dcadfa6a1bb2

Comment 20

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: puppet patch for new staging dir

Comment 21

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 527850 [details] [diff] [review]
puppet patch for new staging dir

Looks fine.  To deploy, land and 'hg pull -u' in /etc/puppet/manifests on all five puppet masters.  Then figure out if surf runs puppet regularly, and if it doesn't, run it manually or just make the change manually.

Note that your patch will not delete the old tryserver-builds directory.  You could do that by puppet or by hand.

Comment 22

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: updates the try_parser test suite for 'try'

Comment 23

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: fix try_sendchange.py

Comment 24

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 527870 [details] [diff] [review]
fix try_sendchange.py

tested on pm02 with my try push

Comment 25

[Aki Sasaki (not active)]

Comment on attachment 527870 [details] [diff] [review]
fix try_sendchange.py

>+            tryDirPath = TRY_BASE_PATH % {'email': email, 
>                                                   'changeset': changeset}

Nit: I'd like this to line up.

>-                    tryserverUrlPath = PLATFORM_BASE_PATH % {'email': email, 
>+                    tryUrlPath = PLATFORM_BASE_PATH % {'email': email, 
>                                                           'changeset': changeset, 
>                                                           'platform': platform}

This too.

Comment 26

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 527870 [details] [diff] [review]
fix try_sendchange.py

http://hg.mozilla.org/build/tools/rev/2bc0a26954d0

landed and updated pm{01,02,03} where try_sendchange is in the ~ dir.

Comment 27

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 527869 [details] [diff] [review]
updates the try_parser test suite for 'try'

landed on default, it can be picked up in the next merge - no rush
http://hg.mozilla.org/build/buildbotcustom/rev/50d0d3dfcd09

Comment 28

[Mark Banner (:standard8)]

I'm not sure why we had to change the ftp directories for try server, but one thing you'll want to do as a result is file a bug on tbpl so that the "go to build directory" will point to the correct place.

Comment 29

[Phil Ringnalda (:philor)]

I'm gonna love him, and hug him, and pet him, and call him bug 652451.

Comment 30

[Lukas Blakk [:lsblakk] use ?needinfo]

I think we're done here.

Comment 31

[Rail Aliiev [:rail]]

Attachment: fix lib/python/build/upload.py

This should fix lib/python/build/upload.py

Comment 32

[Rail Aliiev [:rail]]

Comment on attachment 540862 [details] [diff] [review]
fix lib/python/build/upload.py

http://hg.mozilla.org/build/tools/rev/b383a186ba79

Comment 33

[Gregory Szorc [:gps]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/95aa2282865f