Closed
Bug 650499
Opened 13 years ago
Closed 13 years ago
"ASSERTION: Invalid offset" with soft hyphen, white-space:pre
Categories
(Core :: Layout: Text and Fonts, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jruderman, Assigned: jfkthame)
References
Details
(Keywords: assertion, testcase)
Attachments
(4 files)
306 bytes,
application/xhtml+xml
|
Details | |
3.00 KB,
text/plain
|
Details | |
1.55 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
949 bytes,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
###!!! ASSERTION: Invalid offset: 'aOffset <= mSkipChars->mCharCount', file gfx/thebes/gfxSkipChars.cpp, line 92
Reporter | ||
Comment 1•13 years ago
|
||
Assignee | ||
Comment 2•13 years ago
|
||
Looks like more fallout from bug 418975 and its followup fixes (sigh).
Blocks: 418975
Assignee: nobody → jfkthame
Assignee | ||
Comment 3•13 years ago
|
||
It looks like the problem here arises because the presence of the preformatted newline in the text node means that the textrun ends up "truncated" at that point, so it doesn't cover all the text that the code was expecting it to. To handle this case, we can set len for the PropertyProvider to the minimum of the actual content length and the length covered by the textrun.
Attachment #526712 -
Flags: review?(roc)
Assignee | ||
Comment 4•13 years ago
|
||
Attachment #526714 -
Flags: review?(roc)
Attachment #526712 -
Flags: review?(roc) → review+
Attachment #526714 -
Flags: review?(roc) → review+
Assignee | ||
Comment 5•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/dc4b44f3e3f7 (patch) http://hg.mozilla.org/mozilla-central/rev/b17d5f8022af (testcase)
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 6•13 years ago
|
||
Comment on attachment 526712 [details] [diff] [review] patch, limit length for PropertyProvider to what's actually in the textrun >+ len = PR_MIN(GetContentOffset() + GetInFlowContentLength(), >+ tmp.ConvertSkippedToOriginal(flowEndInTextRun)) - iter.GetOriginalOffset(); This really should have been NS_MIN.
Updated•6 years ago
|
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•