Closed Bug 650553 Opened 13 years ago Closed 10 years ago

[READY] test_webgl_conformance_test_suite.html needs to be explicit about its timeout requirements

Categories

(Core :: Graphics: CanvasWebGL, defect)

Product:
Core
Component:
Graphics: CanvasWebGL
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla32

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

(Whiteboard: webgl-internal)

Attachments

(1 file)

Patch (v1)
1.10 KB, patch
bjacob
: review+
Details | Diff | Splinter Review 
      No description provided.
Attached patch Patch (v1) — — Splinter Review 
Assignee: nobody → ehsan
Status: NEW → ASSIGNED

        Attachment #526520 -
        Flags: review?(bjacob)

    
    

    
  
What does requestFlakyTimeout do?

    
    

    
  
(In reply to comment #2)
> What does requestFlakyTimeout do?

See bug 649012.  It enables the test to use setTimeout(f, t) where t>0 in exceptional cases (such as this one).

These types of timeouts in tests have always been a source of intermittent oranges for us, so I'm planning to disable using them in bug 649012.

        Attachment #526520 -
        Flags: review?(bjacob) → review+

    
  
Summary: test_webgl_conformance_test_suite.html needs to be explicit about its timeout requirements → [READY] test_webgl_conformance_test_suite.html needs to be explicit about its timeout requirements

    
    

    
  
Ehsan, are you still planning to land this?

    
    

    
  
Yes, but all of the dependencies of bug 649012 should get fixed first, and I don't have time to do that right now...
Whiteboard: webgl-internal

    
    

    
  
This probably has severe bitrot. Is this worth saving?
Flags: needinfo?(ehsan)

    
    

    
  
Only if somebody starts to resurrect my work in bug 649012.  This is one of the many dependencies there.
Flags: needinfo?(ehsan)

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/7e7281a034bb
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: