Closed
Bug 650573
Opened 13 years ago
Closed 13 years ago
Panorama hangs when restoring a session
Categories
(Firefox Graveyard :: Panorama, defect)
Firefox Graveyard
Panorama
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 6
People
(Reporter: ttaubert, Assigned: ttaubert)
References
Details
Attachments
(1 file, 3 obsolete files)
6.83 KB,
patch
|
Details | Diff | Splinter Review |
Session restore re-uses (overwrites) opened tabs when restoring a session. Panorama closes all groups not present in the to-be-restored session. If those include re-used tabs, these tabs get closed and SR / Panorama wait until these (now closed) tabs get restored.
Assignee | ||
Comment 1•13 years ago
|
||
Changes: * bug624727.js: disabling private browsing if it wasn't enabled caused this test to fail * bug629195.js: the test must call setWindowState() with aOverwrite = true to meet the test's expectations Passed try: http://tbpl.mozilla.org/?tree=MozillaTry&pusher=tim.taubert@gmx.de&rev=97fb08e090ab
Attachment #526580 -
Flags: feedback?(raymond)
Comment 2•13 years ago
|
||
Comment on attachment 526580 [details] [diff] [review] patch v1 Looks good
Attachment #526580 -
Flags: feedback?(raymond) → feedback+
Assignee | ||
Updated•13 years ago
|
Attachment #526580 -
Flags: review?(ian)
Assignee | ||
Comment 3•13 years ago
|
||
Attachment #526580 -
Attachment is obsolete: true
Attachment #526580 -
Flags: review?(ian)
Attachment #526651 -
Flags: review?(ian)
Assignee | ||
Comment 4•13 years ago
|
||
Comment on attachment 526651 [details] [diff] [review] patch v2 Passed try: http://tbpl.mozilla.org/?tree=MozillaTry&pusher=tim.taubert@gmx.de&rev=44ef323d64e9
Assignee | ||
Comment 5•13 years ago
|
||
Attachment #526651 -
Attachment is obsolete: true
Attachment #526651 -
Flags: review?(ian)
Attachment #526749 -
Flags: review?(ian)
Assignee | ||
Comment 6•13 years ago
|
||
Comment on attachment 526749 [details] [diff] [review] patch v3 Passed try: http://tbpl.mozilla.org/?tree=MozillaTry&pusher=tim.taubert@gmx.de&rev=c3b827e1e649
Comment 7•13 years ago
|
||
Comment on attachment 526749 [details] [diff] [review] patch v3 Paul, can you review this? I'm phasing out my review duties, and would like to spread the Panorama code knowledge around.
Attachment #526749 -
Flags: review?(ian) → review?(paul)
Updated•13 years ago
|
Attachment #526749 -
Flags: review?(sdwilsh)
Comment 8•13 years ago
|
||
Comment on attachment 526749 [details] [diff] [review] patch v3 Review of attachment 526749 [details] [diff] [review]: ----------------------------------------------------------------- r=sdwilsh ::: browser/base/content/test/tabview/browser_tabview_bug624727.js @@ +63,5 @@ > let prefix = 'enter'; > ok(!pb.privateBrowsingEnabled, prefix + ': private browsing is disabled'); > + registerCleanupFunction(function () { > + if (pb.privateBrowsingEnabled) > + pb.privateBrowsingEnabled = false Why do you need the condition here?
Attachment #526749 -
Flags: review?(sdwilsh) → review+
Assignee | ||
Comment 9•13 years ago
|
||
(In reply to comment #8) > ::: browser/base/content/test/tabview/browser_tabview_bug624727.js > @@ +63,5 @@ > > let prefix = 'enter'; > > ok(!pb.privateBrowsingEnabled, prefix + ': private browsing is disabled'); > > + registerCleanupFunction(function () { > > + if (pb.privateBrowsingEnabled) > > + pb.privateBrowsingEnabled = false > > Why do you need the condition here? That's just because of bug 651643. Seems we'll not get it before this one because I still experience some strange try failures there.
Assignee | ||
Comment 10•13 years ago
|
||
Attachment #526749 -
Attachment is obsolete: true
Attachment #526749 -
Flags: review?(paul)
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Updated•13 years ago
|
Comment 11•13 years ago
|
||
Pushed: http://hg.mozilla.org/mozilla-central/rev/24438e77a538
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in cedar]
Target Milestone: --- → Firefox 6
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•