650581 - Test for bug 500328 should avoid using flaky timeouts

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[Justin Lebar (not reading bugmail)]

I'm not even sure why that longWait is there, to be perfectly honest.  Presumably it doesn't work with setTimeout(0).  But if the idiom you replaced it with is useful, then maybe it belongs in SimpleTest?

Thanks for taking on this project, Ehsan.

Comment 3

[(no longer active)]

(In reply to comment #2)
> I'm not even sure why that longWait is there, to be perfectly honest. 
> Presumably it doesn't work with setTimeout(0).

This is used to test to make sure that something doesn't happen.  Depending on the number of events that need to be processed for that thing to happen (in a buggy situation), setTimeout(0) might not work.

>  But if the idiom you replaced
> it with is useful, then maybe it belongs in SimpleTest?

Maybe.  I've used this idiom in a bunch of places so far.  But I think this is something that can easily be done if needed later.  At this point, I don't want to worry about abstracting these types of idioms into SimpleTest functions.

> Thanks for taking on this project, Ehsan.

No problem!  Any help is appreciated BTW.  :-)

Comment 4

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/2e7baa194d4f