650828 - change runtestremote and remotereftests to generate pid file

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Mike Taylor [:bear]]

If we can enable runtestsremote and remotereftests to generate a pid file for themselves, and optionally for their children, then the device prep build step can check to see if older processes are hanging around and kill them.

Comment 1

[Mike Taylor [:bear]]

My preference would be to add a parameter to allow the caller to specify the location and name of the pid file - this would let the build step code put it in the same area as the rest of the pid files we generate.

The the default could be the directory where the process is started for non releng environments

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add --pidfile to the cli which will create a pidfile while the harness is running (1.0)

this patch adds --pidfile to the cli.  Given a filename, this will print the pid to the given filename and will remove the file in the final cleanup step in the harness.

Comment 3

[Mike Taylor [:bear]]

Comment on attachment 526894 [details] [diff] [review]
add --pidfile to the cli which will create a pidfile while the harness is running (1.0)

looks good.  This may be a nit, but I like to wrap the os.remove() with an except catch for OSError so you catch the odd moment when the pidfile goes away during the codes runtime.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add --pidfile to the cli which will create a pidfile while the harness is running (1.1)

updated with warning statement if os.remove() fails!

Comment 5

[cmtalbert]

Comment on attachment 526900 [details] [diff] [review]
add --pidfile to the cli which will create a pidfile while the harness is running (1.1)

Looks good

Comment 6

[cmtalbert]

Landed: http://hg.mozilla.org/mozilla-central/rev/bad2a5a169f5