Closed
Bug 650871
Opened 13 years ago
Closed 13 years ago
nsHttpConnectionMgr.cpp:1064:56: warning: comparison between signed and unsigned integer expressions
Categories
(Core :: Networking: HTTP, defect)
Core
Networking: HTTP
Tracking
()
RESOLVED
FIXED
mozilla6
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
(Whiteboard: [build_warning])
Attachments
(2 files)
1.21 KB,
patch
|
Biesinger
:
review+
mcmanus
:
review+
|
Details | Diff | Splinter Review |
1.33 KB,
patch
|
Details | Diff | Splinter Review |
Filing bug on this warning in up-to-date mozilla-central: > netwerk/protocol/http/nsHttpConnectionMgr.cpp: In member function ‘void nsHttpConnectionMgr::OnMsgReclaimConnection(PRInt32, void*)’: > netwerk/protocol/http/nsHttpConnectionMgr.cpp:1064:56: warning: comparison between signed and unsigned integer expressions The flagged code is: > 1063 PRInt32 idx; > 1064 for (idx = 0; idx < ent->mIdleConns.Length(); idx++) { > 1065 nsHttpConnection *idleConn = ent->mIdleConns[idx]; Looks like idx just wants to be a PRUint32.
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #526769 -
Flags: review?
Assignee | ||
Updated•13 years ago
|
Attachment #526769 -
Flags: review? → review?(jduell.mcbugs)
Assignee | ||
Comment 2•13 years ago
|
||
Note: The last usage of |idx| is line 1071 (the last line in the patch's context): http://mxr.mozilla.org/mozilla-central/search?string=idx&find=nsHttpConnectionMgr.cpp&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central
Updated•13 years ago
|
Attachment #526769 -
Flags: review+
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → dholbert
Updated•13 years ago
|
Attachment #526769 -
Flags: review?(jduell.mcbugs) → review+
Assignee | ||
Comment 3•13 years ago
|
||
Here's the changeset for checkin. (I can't treewatch at the moment; hoping some kind soul can land this & bug 650987 as ridealongs)
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Updated•13 years ago
|
Status: NEW → ASSIGNED
Keywords: checkin-needed
Whiteboard: [build_warning] → [build_warning][fixed in cedar]
Comment 4•13 years ago
|
||
Pushed: http://hg.mozilla.org/mozilla-central/rev/f348404cd074
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [build_warning][fixed in cedar] → [build_warning]
Target Milestone: --- → mozilla6
You need to log in
before you can comment on or make changes to this bug.
Description
•