Closed Bug 651006 Opened 13 years ago Closed 13 years ago

Intermittent Android browser_addons.js | Test timed out

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: philor, Assigned: philor)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Done in Sixty Seconds
1.07 KB, patch
mfinkle
: review+
Details | Diff | Splinter Review 
The log makes it look like this is just an honest "I was still trying to finish my test, you just didn't give me enough time" timeout that just needs a requestLongerTimeout.

Eliding a bit from the failed log http://tinderbox.mozilla.org/showlog.cgi?log=Mobile/1303171998.1303172774.9809.gz#err1

Console message: [timing] main: 2671ms
Console message: [timing] firstPaint: 7944ms
Console message: [timing] sessionRestored: 7653ms
Test 1 took 23675ms
Test 2 took 2709ms
Test 3 took 3773ms
Running test 4
Test timed out
finished in 30226ms

while a successful run is

Console message: [timing] main: 2515ms
Console message: [timing] firstPaint: 5756ms
Console message: [timing] sessionRestored: 5543ms
Test 1 took 18139ms
Test 2 took 2053ms
Test 3 took 3965ms
Test 4 took 530ms
finished in 24793ms

sneaking in just 6 seconds under the wire. The official docs on requestLongerTimeout, wherever they are, say that you are supposed to consider breaking the test up into smaller pieces first, but they weren't written for devices where half your 30 seconds can get burned just by startup time.
Attachment #526884 - Flags: review?(mark.finkle)
Comment on attachment 526884 [details] [diff] [review]
Done in Sixty Seconds

Looks like a reasonable explanation to me
Attachment #526884 - Flags: review?(mark.finkle) → review+
http://hg.mozilla.org/mozilla-central/rev/7d4eb3d3c9de
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
So this can be marked as verified fixed?
Verified that marking bugs as verified is pointless. We're still capable of timing out in browser_addons.js, but I'll declare that any other timeout is not this thing.
Status: RESOLVED → VERIFIED
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: