Closed
Bug 651048
Opened 13 years ago
Closed 13 years ago
Connect to Sync popup is still displayed even if the app is already connected to Sync
Categories
(Firefox for Android Graveyard :: General, defect, P2)
Tracking
(firefox6 fixed, fennec6+)
VERIFIED
FIXED
Firefox 6
People
(Reporter: xti, Assigned: wesj)
References
Details
Attachments
(1 file)
808 bytes,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
This issue is still reproducing on: Build id : Mozilla/5.0 (Android;Linux armv7l;rv:2.1.1)Gecko/20110415 Firefox/4.0.2pre Fennec/4.0.1 Device: Sony Ericsson Xperia X10 OS: Android 2.1 update 1 Steps to reproduce: 1. Open Fennec App 2. Go to Preferences > Sync and tap on Connect button 3. Connect to Sync with valid creditentials 4. Go to about:firstrun 5. Tap on Sync Up Expected result: Connect to Sync popup should not be displayed if the app is already connected to Sync. Actual result: Connect to Sync popup is displayed after step 5. Even if the app is connecting to Sync after step 5 through the popup and the steps 4 and 5 are performed again, there will be the same result: Connect to Sync popup is displayed.
Comment 1•13 years ago
|
||
Madhava - what should happen in this case? Should we show the awesomescreen (desktop tabs) or the preferences page or something else?
Updated•13 years ago
|
tracking-fennec: --- → ?
Priority: -- → P2
Reporter | ||
Updated•13 years ago
|
Summary: Connec to Sync popup is still displayed even if the app is already connected to Sync → Connect to Sync popup is still displayed even if the app is already connected to Sync
Updated•13 years ago
|
Assignee: nobody → wjohnston
Whiteboard: [fennec-6]
Updated•13 years ago
|
tracking-fennec: ? → ---
Updated•13 years ago
|
tracking-fennec: --- → 6+
Whiteboard: [fennec-6]
Assignee | ||
Comment 2•13 years ago
|
||
Putting this up so that we have something. This attempts to open remote tabs when you click it. If you don't have sync set up, trying to open remote tabs will show the connect dialog. Otherwise, it shows remote tabs.
Attachment #530084 -
Flags: review?(mark.finkle)
Comment 3•13 years ago
|
||
Comment on attachment 530084 [details] [diff] [review] Simple fix? function loadSync() { > let win = getChromeWin(); >- win.WeaveGlue.open(); >+ win.BrowserUI.doCommand("cmd_remoteTabs"); Add a comment: // If Sync is not setup, we'll open the setup dialog. Otherwise, we show the remote tabs view
Attachment #530084 -
Flags: review?(mark.finkle) → review+
Comment 4•13 years ago
|
||
Somewhere, there is a different bug about showing a throbber while the remote tabs view does it's initial sync... it's bug 653146
Assignee | ||
Comment 5•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/7db1f707c11c
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 6•13 years ago
|
||
Verified fixed on build: Mozilla /5.0 (Android;Linux armv7l;rv:6.0a1) Gecko/20110508 Firefox/6.0a1 Fennec/6.0a1 Device: LG Optimus 2X (Android 2.2)
Status: RESOLVED → VERIFIED
Updated•13 years ago
|
Target Milestone: --- → Firefox 6
Updated•13 years ago
|
status-firefox6:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•