651074 - JavaScript doesn't work with Google Map (marks)

Status: RESOLVED FIXED

(Tech Evangelism Graveyard :: English US, defect)

Description

[Saibamen]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0) Gecko/20100101 Firefox/4.0
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0) Gecko/20100101 Firefox/4.0

In ReactOS People Map (http://www.reactos.org/peoplemap/) if i select User, Translator or Language Maintainer - marks doesn't work. For Newsletter Author, Developer and Moderator it works.

Reproducible: Always

Steps to Reproduce:
1. Go to http://www.reactos.org/peoplemap/
2. Select User, Translator, Language Maintainer
Actual Results:  
Marks doesn't work.


This happend only on Firefox and IE.

Comment 1

[Srinivas]

Confirmed unable to filter users by selecting User, Translator, Language Maintainer

Able to reproduce in Firefox 3.6.16, 4.0

Comment 2

[Alice0775 White]

Response xml source contains invalid UTF-8 character of U+FFFF. 
I think this is TE.

Error in error console:

*Checked "Language Maintainer"

Error: not well-formed
Source file: http://www.reactos.org/peoplemap/ajax-getuser.php?query=3&subject=group&
Line: 1, Column: 538
Source code:
...
<fullname>Vytis Girdï¿¿ijauskas</fullname>

*Checked "Translator"

Error: not well-formed
Source file: http://www.reactos.org/peoplemap/ajax-getuser.php?query=9&subject=group&
Line: 1, Column: 967
Source code:
...
<fullname>Vytis Girdï¿¿ijauskas</fullname>

*Checked "User"
Error: not well-formed
Source file: http://www.reactos.org/peoplemap/ajax-getuser.php?query=10&subject=group&
Line: 1, Column: 7012
Source code:
...
<fullname>Tomi Mï¿¿kinen</

Comment 3

[Dave Miller [:justdave]]

alice0775: you might want to put that up as an attachment if people actually need to see it.  I had to remove the characters you're complaining about in order for Bugzilla to display it.

Comment 4

[Alice0775 White]

Attachment: Responced xml when checked "User"

Invalid UTF-8 is includes in response xml.
Encoding error is treated as fatal XML errors.
This was introduced by Bug 174351.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Indeed, this looks like tech evangelism.  WebKit uses an XML parser that will output a partial DOM even if it hits a fatal error (and it might not even treat encoding errors as fatal).

Comment 6

[Boris Zbarsky [:bzbarsky]]

I've emailed the website coordinator as listed at http://www.reactos.org/en/contact.html

Comment 7

[Saibamen]

Fixed.

Comment 8

[Daniel C]

As far as I can tell by looking at the URLs in comment 2, they "fixed" this by just deleting the characters...

Instead of sending an HTTP charset, or adding an XML processing instruction, or actually using UTF-8 (which would be the best solution), the 3 names in comment 2 have just been sanitized and had their nasty non-ASCII characters removed.

Vytis Girdijauskas should probably be Vytis Girdžijauskas and Tomi Mkinen should probably be Tomi Mäkinen.

Comment 9

[Saibamen]

http://svn.reactos.org/svn/web/trunk/www/www.reactos.org/peoplemap/ajax-getuser.php?r1=606&r2=605&pathrev=606

Comment 10

[Daniel C]

OK, I missed the part where the characters were U+FFFF. The change you made will stop encoding errors on the output by outputting numeric entities for characters above U+FF. In this case, it doesn't output anything though (which also avoids the encoding error) because U+FFFF isn't a valid character. Somewhere you have another problem where UTF-8 isn't being handled correctly and you're storing U+FFFF in the database instead of the actual characters. Once you fix that problem and replace/remove the invalid characters in the database, you won't need the change you made and can just output the characters raw (as the XML file is assumed to be UTF-8).