Closed
Bug 651075
Opened 13 years ago
Closed 13 years ago
Make content/html/content/test/test_bug386496.html non flaky
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla6
People
(Reporter: mounir, Assigned: mounir)
References
Details
Attachments
(1 file)
|
2.98 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
I didn't found any obvious way to do that.
|
||
Comment 1•13 years ago
|
||
Set an unload event handler on the iframe, switch to setTimeout(0) and make sure that the event handler is not called.
|
Assignee | |
Comment 2•13 years ago
|
||
|
|
Assignee | |
Updated•13 years ago
|
Attachment #527562 -
Attachment description: Basically a rewrite of the patch → Basically a rewrite of the test
|
|
Assignee | |
Updated•13 years ago
|
Whiteboard: [needs review]
|
|
Assignee | |
Comment 3•13 years ago
|
||
And FTR, this test was testing nothing: the timeout was too low to really catch a failure and when higher, the failure was because the check was forbidden (js exception was thrown). Lovely flaky one.
|
|
||
Comment 4•13 years ago
|
||
Comment on attachment 527562 [details] [diff] [review] Basically a rewrite of the test Review of attachment 527562 [details] [diff] [review]: Looks good!
Attachment #527562 -
Flags: review?(ehsan) → review+
|
|
Assignee | |
Updated•13 years ago
|
Whiteboard: [needs review] → [fixed in cedar]
|
|
Assignee | |
Comment 5•13 years ago
|
||
Pushed: http://hg.mozilla.org/mozilla-central/rev/ebf02b534397
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed in cedar]
Target Milestone: --- → mozilla6
You need to log in
before you can comment on or make changes to this bug.
Description
•