Closed
Bug 651079
Opened 13 years ago
Closed 13 years ago
Use addLoadEvent instead of <body onload=""> in content/html/content/tests/
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla6
People
(Reporter: mounir, Assigned: mounir)
Details
Attachments
(1 file, 1 obsolete file)
|
24.52 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #526953 -
Flags: review?(ehsan)
|
Assignee | |
Comment 1•13 years ago
|
||
With even more of those. Though, it's really not important.
Attachment #526953 -
Attachment is obsolete: true
Attachment #526953 -
Flags: review?(ehsan)
Attachment #526957 -
Flags: review?(ehsan)
|
|
Assignee | |
Updated•13 years ago
|
Whiteboard: [needs review]
|
||
Comment 2•13 years ago
|
||
Hmm, the onload property should work just as good as a callback passed to addLoadEvent. I'm not sure what is the purpose behind these patches.
|
|
Assignee | |
Comment 3•13 years ago
|
||
(In reply to comment #2) > Hmm, the onload property should work just as good as a callback passed to > addLoadEvent. I'm not sure what is the purpose behind these patches. It's much more a clean-up than a QA improvement: I think having the onload in <body> is much more hard to parse than a addLoadEvent that should usually be at the beginning or at the end of the <script> section.
|
|
||
Comment 4•13 years ago
|
||
Comment on attachment 526957 [details] [diff] [review] Patch v2 OK, fair enough.
Attachment #526957 -
Flags: review?(ehsan) → review+
|
|
Assignee | |
Comment 5•13 years ago
|
||
Pushed: http://hg.mozilla.org/mozilla-central/rev/1ebe64a0f85f
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [needs review]
Target Milestone: --- → mozilla6
You need to log in
before you can comment on or make changes to this bug.
Description
•