Closed
Bug 651262
Opened 13 years ago
Closed 13 years ago
Update histogram.h/cc
Categories
(Core :: IPC, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: taras.mozilla, Assigned: taras.mozilla)
References
Details
Attachments
(3 files)
|
108.61 KB,
patch
|
cjones
:
review+
|
Details | Diff | Splinter Review |
|
2.11 KB,
patch
|
cjones
:
review+
|
Details | Diff | Splinter Review |
|
1.70 KB,
patch
|
bent.mozilla
:
review+
|
Details | Diff | Splinter Review |
Update histogram classes to chromium trunk
Attachment #527132 -
Flags: review?(jones.chris.g)
|
Assignee | |
Comment 1•13 years ago
|
||
This is the minimal set of changes to get newer chrome code in. This is my first code-borrowing attempt, so I probably did it wrong.
Attachment #527133 -
Flags: review?(jones.chris.g)
|
|
Assignee | |
Updated•13 years ago
|
I don't mind rubber-stamping these patches, but it doesn't make a lot of sense for us to build a dependency on code that's not meant to be used externally. Please don't be shy about forking. (We may be forced to do that anyway if there's a pending rewrite on the chromium side.)
Comment on attachment 527132 [details] [diff] [review] Copy new histogram.* files rs=me
Attachment #527132 -
Flags: review?(jones.chris.g) → review+
Comment on attachment 527133 [details] [diff] [review] hacks to keep things compiling rs=me
Attachment #527133 -
Flags: review?(jones.chris.g) → review+
|
|
Assignee | |
Comment 5•13 years ago
|
||
(In reply to comment #2) > I don't mind rubber-stamping these patches, but it doesn't make a lot of sense > for us to build a dependency on code that's not meant to be used externally. > Please don't be shy about forking. (We may be forced to do that anyway if > there's a pending rewrite on the chromium side.) Thanks. I'd like to leverage the painful lessons that they learned for as long as I can. We can fork it once we know what works for us.
Certainly, that's been the m.o. with the IPC stuff.
|
|
Assignee | |
Comment 7•13 years ago
|
||
This is a small compilation fix on windows. Had this attached to the wrong bug before.
Attachment #528396 -
Flags: review?(jones.chris.g)
|
||
Updated•13 years ago
|
Attachment #528396 -
Flags: review?(jones.chris.g) → review+
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 8•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/28ddb101c4ac http://hg.mozilla.org/mozilla-central/rev/ecd8499c7828 http://hg.mozilla.org/mozilla-central/rev/00431dc35e33
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Updated•13 years ago
|
Assignee: nobody → tglek
You need to log in
before you can comment on or make changes to this bug.
Description
•