Closed Bug 651265 Opened 13 years ago Closed 13 years ago

Wrong tooltip for lines column header (news)

Categories

(Thunderbird :: Folder and Message Lists, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Thunderbird 5.0b1

People

(Reporter: stef, Assigned: stef)

Details

Attachments

(1 file, 1 obsolete file)

Originally reported as Aviary.pl bug 3891 (http://bugs.aviary.pl/show_bug.cgi?id=3891).

If you hoover the lines column header (available in newsgroup folder), wrong tooltip (sizeColumnTooltip) will be displayed.
Attached patch comm-central patch (obsolete) — Splinter Review
Attachment #527137 - Flags: review?(bugmail)
Assignee: nobody → splewako
Status: NEW → ASSIGNED
Comment on attachment 527137 [details] [diff] [review]
comm-central patch

Shouldn't you also be setting the "tooltiptext" to sizeColumnTooltip on the else clause too then?
Attachment #527137 - Flags: review?(bugmail) → review-
Attached patch patch v2Splinter Review
(In reply to comment #2)
> Shouldn't you also be setting the "tooltiptext" to sizeColumnTooltip on the
> else clause too then?

Right, I should. And another patch/bug for SM?
Attachment #527137 - Attachment is obsolete: true
Attachment #528553 - Flags: review?(bugmail)
Comment on attachment 528553 [details] [diff] [review]
patch v2

Review of attachment 528553 [details] [diff] [review]:

Looks good, thank you.

I'm not really sure how it works with SeaMonkey; usually when a commit goes by for the Thunderbird UI they file a new bug to port the changes from that bug to SeaMonkey.
Attachment #528553 - Flags: review?(bugmail) → review+
Checked in: http://hg.mozilla.org/comm-central/rev/5ce2b112e486
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.3a4
Verified with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:5.0a2) Gecko/20110503 Thunderbird/3.3a4pre, thx.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: