Closed
Bug 651657
Opened 13 years ago
Closed 13 years ago
Remove WinCE & Windows Mobile code from dom/*
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
VERIFIED
FIXED
mozilla6
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file, 1 obsolete file)
12.51 KB,
patch
|
emorley
:
review+
|
Details | Diff | Splinter Review |
WinCE & Windows Mobile code is being slowly removed by bug 614720 - since it's broken, no longer supported, and only serves to complicate code maintenance. This bug is for the dom/* parts of the removal.
Assignee | ||
Comment 1•13 years ago
|
||
Remove WinCE & Windows Mobile ifdefs from dom/* + hg rm WinMobileLocationProvider.(h|cpp) Justin hope you don't mind another r? ; this is much smaller than the patch in the other bug at least! :-)
Attachment #527422 -
Flags: review?(dolske)
Assignee | ||
Comment 2•13 years ago
|
||
Passed try (after repeating a few of the tests for intermittent oranges): http://dev.philringnalda.com/tbpl/?tree=Try&rev=cca063ae0577
Comment 3•13 years ago
|
||
Comment on attachment 527422 [details] [diff] [review] Remove WinCE & Windows Mobile code from dom/* Bouncing over to jst, looks fine to me though.
Attachment #527422 -
Flags: review?(jst)
Attachment #527422 -
Flags: review?(dolske)
Attachment #527422 -
Flags: review+
Comment 4•13 years ago
|
||
Comment on attachment 527422 [details] [diff] [review] Remove WinCE & Windows Mobile code from dom/* Review of attachment 527422 [details] [diff] [review]: r=jst
Attachment #527422 -
Flags: review?(jst) → review+
Assignee | ||
Comment 5•13 years ago
|
||
Only change is updated commit message to include the r=jst,dolske. Carrying forwards r+
Attachment #527422 -
Attachment is obsolete: true
Attachment #528969 -
Flags: review+
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Comment 6•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/c39785cf8fb8
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
Comment 7•13 years ago
|
||
Build: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:6.0) Gecko/20100101 Firefox/6.0 The changes made in m-c and landed (comment 6) are visible in hg, under beta (i.e. the file WinMobileLocationProvider.cpp is not available anymore). Setting this as verified for Firefox 6 Beta
Status: RESOLVED → VERIFIED
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•