651861 - ipc/chromium compilation broken on mingw

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Jacek Caban]

Attachment: fix v1.0

There are a few problems with compilation on mingw. The attached patch fixes all of them (I'm not requesting review yet as I need to get one last fix committed to mingw-w64 project first). The changes are:

Makefile.in, debug_on_start.h:
Disable debug_on_start on mingw (make it depend on compiler instead of OS)

chromium-config.mk:
Make -DCOMPILER_MSVC depend on compiler instead of OS

atomicops.h:
Use MSVC version of tomicops_internals_* on mingw

atomicops_internals_x86_msvc.h:
MSC version check makes sense only on MSVC

file_path.cc, file_path.h, file_util.cc:
GCC lacks UNICODE version of ifstream constructor, but we use UNICODE paths on Windows. Workaround the problem by converting path to ASCII version.

message_loop.cc, platform_thread_win.cc:
Use MOZ_SEH_TRY/MOZ_SEH_EXCEPT instead of __try/__except to workaround GCC's lack of SEH support.

prtime.cc, time_win.cc:
Use proper macro for long long constants instead of MSC-specific syntax.

win_util.cc:
Do function pointer to pointer cast explicitly (GCC throws an error otherwise).

Comment 1

[Jacek Caban]

Thanks for the review, patch pushed to m-c:

http://hg.mozilla.org/mozilla-central/rev/c447a4e42b62