Closed
Bug 651872
Opened 13 years ago
Closed 13 years ago
Create access key for Workspace menu item
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 6
People
(Reporter: rcampbell, Assigned: msucan)
Details
(Whiteboard: [workspace][fixed-in-devtools][merged-to-mozilla-central])
Attachments
(1 file)
|
2.07 KB,
patch
|
Pike
:
review-
rcampbell
:
review+
|
Details | Diff | Splinter Review |
browser-menubar.inc doesn't have an access key for the workspace menu item. We should add one, based on https://bugzilla.mozilla.org/show_bug.cgi?id=642176#c35.
|
Assignee | |
Comment 1•13 years ago
|
||
Add the accesskey for the Workspace menuitem.
Assignee: nobody → mihai.sucan
Status: NEW → ASSIGNED
Attachment #527552 -
Flags: review?(l10n)
Attachment #527552 -
Flags: feedback?(rcampbell)
|
Reporter | |
Comment 2•13 years ago
|
||
Comment on attachment 527552 [details] [diff] [review] [checked-in][in-devtools]accesskey looks good. I'm going to wager l10n will deem this acceptable.
Attachment #527552 -
Flags: feedback?(rcampbell) → review+
|
|
Reporter | |
Comment 3•13 years ago
|
||
Comment on attachment 527552 [details] [diff] [review] [checked-in][in-devtools]accesskey http://hg.mozilla.org/projects/devtools/rev/1caae16935f9
Attachment #527552 -
Attachment description: accesskey → [in-devtools]accesskey
|
|
Reporter | |
Updated•13 years ago
|
Whiteboard: [workspace] → [workspace][fixed-in-devtools]
|
||
Comment 4•13 years ago
|
||
Comment on attachment 527552 [details] [diff] [review] [checked-in][in-devtools]accesskey I think this should be an "o", actually. https://developer.mozilla.org/en/XUL_Accesskey_FAQ_and_Policies is a good read on how to choose accesskeys in general, fwiw.
|
|
||
Comment 5•13 years ago
|
||
Comment on attachment 527552 [details] [diff] [review] [checked-in][in-devtools]accesskey PS: I'm not an expert in a11y, sadly. Or luckily. Can't check for conflicts here on OSX easily, either, as it doesn't show accesskeys. You should check on win or linux.
Attachment #527552 -
Flags: review?(l10n) → review-
|
|
Reporter | |
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [workspace][fixed-in-devtools] → [workspace][fixed-in-devtools][merged-to-mozilla-central]
Target Milestone: --- → Firefox 6
|
|
Reporter | |
Comment 6•13 years ago
|
||
Comment on attachment 527552 [details] [diff] [review] [checked-in][in-devtools]accesskey http://hg.mozilla.org/mozilla-central/rev/1caae16935f9
Attachment #527552 -
Attachment description: [in-devtools]accesskey → [checked-in][in-devtools]accesskey
|
||
Comment 7•13 years ago
|
||
Verified fixed on: Mozilla/5.0 (Windows NT 6.1; rv:6.0a1) Gecko/20110511 Firefox/6.0a1 Mozilla/5.0 (X11; Linux i686; rv:6.0a1) Gecko/20110512 Firefox/6.0a1 having the letter "s" as an access key in the menu There is no letter assigned in the menu on Mac: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:6.0a1) Gecko/20110511 Firefox/6.0a1
|
||
Updated•13 years ago
|
Status: RESOLVED → VERIFIED
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•