652016 - When switching channels, I get a failed update

Status: VERIFIED FIXED

(Toolkit :: Application Update, defect)

Description

[LegNeato]

Attachment: Screenshot 1

1. Check the about dialog on an older build on the aurora channel
2. Make sure there is an update already downloaded and ready to install (the button says "Apply Update")
3. Change to the "Beta" channel
4. Click "Apply and Update"
5. Notice an update downloads, even though one was 100% downloaded previously
6. Get an "Update failed" message

Comment 1

[LegNeato]

Attachment: Screenshot 2

Comment 2

[LegNeato]

Attachment: Screenshot 3

Comment 3

[LegNeato]

Attachment: Screenshot 4

Comment 4

[Robert Strong (they/them - no direct email)]

limi, what UX behavior should we have? For example, if there is an update ready to apply should the user have the ability to change the channel?

Comment 5

[LegNeato]

Attachment: Update log

Update log attached. I haven't tried to see if it works itself out yet.

Comment 6

[Robert Strong (they/them - no direct email)]

No more files are needed... btw: the update.log is from the previously applied update and there is no log file for the failed download.

Comment 7

[Alex Limi (:limi) — Firefox UX Team]

(In reply to comment #4)
> limi, what UX behavior should we have? For example, if there is an update ready
> to apply should the user have the ability to change the channel?

Yes, you should always be able to change the channel.

If there's an update queued for e.g. the Beta channel and you want to switch to the Aurora channel, we should discard the update and get the Aurora one instead.

Comment 8

[Robert Strong (they/them - no direct email)]

Attachment: patch in progress

Comment 10

[Asa Dotzler [:asa]]

will look again at a patch approval request but not going to track this through this flag.

Comment 11

[Sheila Mooney]

Hey Rob, is your intent to get this fixed for FF5?

Comment 12

[Robert Strong (they/them - no direct email)]

I've got a patch but I've had trouble finishing up the tests and my eye problems flared up again... still hopeful to have it done today.

Comment 13

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Dave, I'll followup with tests later after I get replacement eyeglasses

Comment 14

[Robert Strong (they/them - no direct email)]

Attachment: main patch rev1

Comment 15

[Robert Strong (they/them - no direct email)]

Attachment: tests rev1

Comment 16

[Dave Townsend [:mossop]]

Comment on attachment 532863 [details] [diff] [review]
main patch rev1

Review of attachment 532863 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/mozapps/update/nsUpdateService.js
@@ +500,5 @@
>    var channelChangeFile = dir.clone();
>    channelChangeFile.append(FILE_CHANNELCHANGE);
> +  if (!channelChangeFile.exists())
> +    channelChangeFile.create(Ci.nsILocalFile.NORMAL_FILE_TYPE,
> +                             FileUtils.PERMS_FILE);

nit: braces around this

Comment 17

[Dave Townsend [:mossop]]

Comment on attachment 532895 [details] [diff] [review]
tests rev1

Review of attachment 532895 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 18

[Robert Strong (they/them - no direct email)]

Comment on attachment 532863 [details] [diff] [review]
main patch rev1

Requesting approval for Aurora and Beta before landing on m-c since the code is only exercised on Aurora and Beta

Comment 19

[Johnathan Nightingale [:johnath]]

Missed this approval for aurora before the merge, but if you land it on central now, it'll get picked up in next week's aurora merge for FF6 and the world will be a happier place for Aurora users at least. We can take it on beta after that, or wait 6 weeks for it to get there on its own, based on the risk/reward calculus for those users.

Comment 20

[Robert Strong (they/them - no direct email)]

Attachment: main patch rev2 - updated to comments

Comment 21

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/195b5dc114c5
http://hg.mozilla.org/mozilla-central/rev/062dccbd5674

Comment 22

[Robert Strong (they/them - no direct email)]

Comment on attachment 533340 [details] [diff] [review]
main patch rev2 - updated to comments

Readding the beta approval request

Comment 23

[Asa Dotzler [:asa]]

Comment on attachment 533340 [details] [diff] [review]
main patch rev2 - updated to comments

Please land this change on both Aurora and Beta. (In the future, getting changes in during Aurora will save you this extra step.)

Comment 24

[Robert Strong (they/them - no direct email)]

Pushed to mozlla-aurora
http://hg.mozilla.org/releases/mozilla-aurora/rev/21f2117c6eb1
http://hg.mozilla.org/releases/mozilla-aurora/rev/90a0d1cdff11

Pushed to mozlla-beta
http://hg.mozilla.org/releases/mozilla-beta/rev/a9152271fee4
http://hg.mozilla.org/releases/mozilla-beta/rev/546612551fbd

Comment 25

[George Carstoiu]

Mozilla/5.0 (Windows NT 5.1; rv:5.0) Gecko/20100101 Firefox/5.0 - Firefox 5 Beta - build 3

Verified the issue on WinXP and it's no longer reproducible.
The update testing was done between Aurora 6.0a2 to Beta 5.0b3.