Closed Bug 652109 Opened 13 years ago Closed 13 years ago

SetProcessDPIAware is called regardless if the process is really DPI aware

Categories

(Core :: Widget: Win32, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla7

People

(Reporter: jacek, Assigned: jacek)

Details

Attachments

(1 file)

Attached patch fix v1.0Splinter Review
Although it may be fine for all Mozilla products to call SetProcessDPIAware on xul.dll load, in embedding situation it may not be good as the rest of the process may be not DPI aware. The fix is as simple as moving the call to XRE_main, where other similar settings are done.
Attachment #527759 - Flags: review?(roc)
Keywords: checkin-needed
patching file toolkit/xre/nsAppRunner.cpp
Hunk #1 FAILED at 2775
1 out of 1 hunks FAILED -- saving rejects to file toolkit/xre/nsAppRunner.cpp.rej
patching file widget/src/windows/nsToolkit.cpp
Hunk #1 FAILED at 217
1 out of 1 hunks FAILED -- saving rejects to file widget/src/windows/nsToolkit.cpp.rej
Keywords: checkin-needed
Thanks for an attempt to commit it. I was planning to commit it myself, but my build environment is temporary broken. I will rebase and push once I will fix it.
Pushed to cedar:
http://hg.mozilla.org/projects/cedar/rev/25e9a51b01be
Whiteboard: fixed-in-cedar
Pushed:
http://hg.mozilla.org/mozilla-central/rev/25e9a51b01be
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
Target Milestone: --- → mozilla7
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: