Closed
Bug 652157
Opened 13 years ago
Closed 13 years ago
JavaScript Error: "scrollbox.firstChild is null"
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 6
People
(Reporter: wesj, Assigned: wesj)
References
Details
Attachments
(1 file, 1 obsolete file)
3.01 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
This shows up during a lot of test runs. When I updated the dialog theme, I also switched to using dialog elements in our main chrome. That also attaches the dialog binding which contains some properties that don't really apply to those dialogs. This patch just removes the binding for these two guys.
Assignee | ||
Updated•13 years ago
|
Attachment #527808 -
Attachment is patch: true
Attachment #527808 -
Attachment mime type: application/octet-stream → text/plain
Attachment #527808 -
Flags: review?(mark.finkle)
Comment 1•13 years ago
|
||
Comment on attachment 527808 [details] [diff] [review] Patch can you just change the main binding to use: dialog:not(.content-dialog) { -moz-binding: url("chrome://browser/content/bindings/dialog.xml#dialog"); }
Assignee | ||
Comment 2•13 years ago
|
||
Sure.
Assignee: nobody → wjohnston
Attachment #527808 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #527808 -
Flags: review?(mark.finkle)
Comment 3•13 years ago
|
||
Comment on attachment 527843 [details] [diff] [review] Patch v2 I assume this works OK and you want a review :)
Attachment #527843 -
Flags: review+
Assignee | ||
Comment 4•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/6edb7954577c
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Target Milestone: --- → Firefox 6
Comment 5•13 years ago
|
||
VERIFIED FIXED on: Build ID: Mozilla /5.0 (Android;Linux armv7l;rv:6.0a2) Gecko/20110705 Firefox/6.0a2 Fennec/6.0a2 Device: HTC Desire Z (Android 2.2)
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•