652320 - Closing tabs leaves an empty space on the right when tabbar is scrolled to the right

Status: RESOLVED WONTFIX

(Firefox :: Tabbed Browser, defect)

Description

[Mike Hommey [:glandium]]

See
https://bugzilla.mozilla.org/show_bug.cgi?id=465086#c251
and
https://bug465086.bugzilla.mozilla.org/attachment.cgi?id=525653

Comment 1

[Mike Hommey [:glandium]]

A few more specifics. This happens when there are a lot of open tabs and the tabbar is scrolled up to the last tab.
- when closing the last tab, all tabs are scrolled to the right
- when closing other tabs, tabs on the right of the closed tab are scrolled to the left, leaving an empty space on the right. This feels weird.

I believe the latter should have the same kind of behaviour as the former.

Comment 2

[Mike Hommey [:glandium]]

See also https://bugzilla.mozilla.org/show_bug.cgi?id=465086#c194 , point 2.

Comment 3

[Bill Gianopoulos [:WG9s]]

So, it seems that the code added to address the second issue I pointed out in https://bugzilla.mozilla.org/show_bug.cgi?id=465086#c194 does not work in the case where the tabbar has been scrolled to the right.

Comment 4

[Frank Yan (:fryn)]

(In reply to comment #1)
> A few more specifics. This happens when there are a lot of open tabs and the
> tabbar is scrolled up to the last tab.
> - when closing the last tab, all tabs are scrolled to the right
> - when closing other tabs, tabs on the right of the closed tab are scrolled to
> the left, leaving an empty space on the right. This feels weird.
> 
> I believe the latter should have the same kind of behaviour as the former.

This is intended behavior. Making it easy to close the next tab is more important than seeing all of your tabs as once, which wouldn't be able to anyways since you already opened enough tabs to be in overflow mode.

(In reply to comment #3)
> So, it seems that the code added to address the second issue I pointed out in
> https://bugzilla.mozilla.org/show_bug.cgi?id=465086#c194 does not work in the
> case where the tabbar has been scrolled to the right.

The reason for moving the tab on the right to fill the space is that the tab on the right is very likely the tab that will be selected upon closing a tab. It is more helpful to be able to see the tab before you decide to close it by clicking.

Comment 5

[Mike Hommey [:glandium]]

Frank, would you mind to elaborate?

Comment 6

[Mike Hommey [:glandium]]

(In reply to comment #5)
> Frank, would you mind to elaborate?

Forget this, I hadn't seen comment 4.

Comment 7

[Mike Hommey [:glandium]]

Kind of makes sense, though confusing at first.
There's however an unexpected side effect: when you close tabs and scroll the tabbar on the left, and then on the right again, you can continue scrolling after the last tab, recreating the empty space you created by closing the tabs.