652355 - Remove virtual accessor GetURIExternal from Link

Status: RESOLVED WONTFIX

(Core :: DOM: Navigation, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

This was added in Bug 510202 and can go away now that we live in a libxul only world.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Remove virtual accessor used as a non-libxul workaround now that disable-libxul is dead.

Comment 2

[Shawn Wilsher :sdwilsh]

Comment on attachment 527959 [details] [diff] [review]
Remove virtual accessor used as a non-libxul workaround now that disable-libxul is dead.

r=sdwilsh

Comment 3

[Boris Zbarsky [:bzbarsky]]

Is this not meant for use by non-core code, then?  _That_'s not linked into libxul....

Comment 4

[Shawn Wilsher :sdwilsh]

(In reply to comment #3)
> Is this not meant for use by non-core code, then?  _That_'s not linked into
> libxul....
That's a good point.  Maybe we don't want this change?

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Well, I got the impression that we did this just for that one use case ... if we don't want this, WONTFIX the bug.

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

So, who gets to make that call? Bz?

Comment 7

[Boris Zbarsky [:bzbarsky]]

Unless there's obvious harm from having this (which I don't see yet), I'd just keep it.