652408 - [meta] Re-enable jstests in |make check|

Status: RESOLVED WORKSFORME

(Core :: JavaScript Engine, defect)

Description

[Paul Biggar]

Enabling jstests in |make check| has bounced many times, which only increases it's desirability since so many things are broken! This meta is to track getting it turned on fully.

Comment 1

[Paul Biggar]

Attachment: Enable jstests on all platforms

This adds jstests to |make check|, and currently is all green. There are a number of subtests which fail on various platforms, this just disables them.

Comment 2

[Bob Clary [:bc] (inactive)]

Considering bug 992323 where make check has met its waterloo, we should repurpose this bug to making the shell jstests run on the test machines just as the other test suites do.

Paul, would you mind if we morph this bug and would you like to drive it? Otherwise we should probably wontfix it and file a new bug to enable the shell jstests as part of our normal test runs.

Perhaps ted can help guide us on exactly how we should do that.

Comment 3

[(not currently active) Ted Mielczarek]

The dependency tree of bug 858621 is a pretty good example of what it takes to get a set of tests up and running on par with the other tests we run.

Comment 4

[Paul Biggar]

@bclary: Sure! I'm no longer actively involved, so please feel free to morph any of my bugs as appropriate :)

Comment 5

[Bryan Thrall [:bthrall]]

Currently, jstests are enabled via ./mach jstests.