652711 - Features page doesn't validate

Status: VERIFIED FIXED

(Websites :: webifyme.org, defect, P3)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

http://webifyme-dev.allizom.org/features/ doesn't validate:

    Error: The charset attribute on the link element is obsolete. Use an HTTP Content-Type header on the linked resource instead.

    From line 8, column 3; to line 8, column 85

    tle>↩ ↩ <link rel="stylesheet" href="/static/css/base.css" type="text/css" charset="utf-8">↩ ↩

    Error: Duplicate ID feature-3.

    From line 83, column 1; to line 83, column 40

    >↩</div>↩↩<div class="paper-strip" id="feature-3">↩ <im

    Warning: The first occurrence of ID feature-3 was here.

    From line 80, column 2; to line 80, column 40

    ↩ </div>↩ <div class="bottom-cap" id="feature-3"></div>

    Error: Bad value for attribute action on element form: Must be non-empty.

    From line 216, column 7; to line 216, column 36

    m">↩ <form action="" method="post">↩ <div

    Syntax of IRI reference:
        Any URL. For example: /hello, #canvas, or http://example.org/. Characters should be represented in NFC and spaces should be escaped as %20.

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

http://webifyme-dev.allizom.org/features/, not example.org -- Bugzilla has a bug, I think :-(

Comment 2

[Adam Miller]

After this commit, it should validate fine. 

https://github.com/mozilla/webifyme/commit/ec052e7e62ae85376b48d5b06090f34be1698a06

Comment 3

[William Reynolds [:williamr]]

Marking resolved per comment 2. Thanks Adam!

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Some other commit must have regressed this; reopening.

Comment 5

[Adam Miller]

and fixing again: https://github.com/mozilla/webifyme/commit/0195b803140831632b1b525904c6b6ea390364c5

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on http://html5.validator.nu/?doc=http%3A%2F%2Fwebifyme-dev.allizom.org%2Ffeatures%2F.

Thanks, Adam.  If this regresses again, I'll just open a new bug.