Closed
Bug 652970
Opened 13 years ago
Closed 13 years ago
nsXULDocument doesn't unlink enough
Categories
(Core :: XUL, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: smaug, Assigned: smaug)
References
Details
Attachments
(1 file, 1 obsolete file)
|
2.62 KB,
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
If nodes' ownerDocument is made a strong, we leak XULDocuments because it doesn't unlink mTemplateBuilderTable.
Attachment #528442 -
Flags: review?(peterv)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 528442 [details] [diff] [review] patch Would it make sense to make nsXULDocument::SetTemplateBuilderFor check if aBuilder is non-null before creating a new BuilderTable? I'm worried about unlinking of other objects ending up calling SetTemplateBuilderFor with a null aBuilder. Add a comment that we should unlink all the other stuff that we traverse too.
|
Assignee | |
Comment 2•13 years ago
|
||
Attachment #528442 -
Attachment is obsolete: true
Attachment #528442 -
Flags: review?(peterv)
Attachment #528568 -
Flags: review?(peterv)
|
|
||
Updated•13 years ago
|
Attachment #528568 -
Flags: review?(peterv) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/557466969ba2
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•