653056 - Figure out why Visual Studio PGO miscompiles JSDOUBLE_IS_NAN

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Use a bitwise version of JSDOUBLE_IS_NaN that Visual Studio PGO doesn't miscompile

I found in bug 653777 that this variant apparently doesn't trigger the MSVC miscompilation. However, the patch there was also moving the function, so I'll push to try to confirm this version is fine.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Does MSVC2010 have the issue as well?

Comment 3

[Mike Hommey [:glandium]]

Attachment: Use a bitwise version of JSDOUBLE_IS_NaN that Visual Studio PGO doesn't miscompile

JSDOUBLE_HI32_NAN needed to be moved, so I moved the whole block of defines

Comment 4

[Jim Blandy :jimb]

Comment on attachment 546102 [details] [diff] [review]
Use a bitwise version of JSDOUBLE_IS_NaN that Visual Studio PGO doesn't miscompile

Review of attachment 546102 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 5

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/41e4d29fb76d

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/41e4d29fb76d