Closed
Bug 653086
Opened 13 years ago
Closed 13 years ago
clean up editor configuration lines in a11y files
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: tbsaunde, Assigned: tbsaunde)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
33.78 KB,
patch
|
surkov
:
review+
|
Details | Diff | Splinter Review |
34.59 KB,
patch
|
fherrera
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0a1) Gecko/20110425 Firefox/6.0a1 Build Identifier: before we tart reindenting atk/ to use 2 space t indents instead of 4 we should change the editor configuration lines to use 2 spaces instead of 4. Also while doing this outside of atk/ there where a few files that had no such lines and many others that only had emacs ones, make sure all these files have ones for both vim and emacs. Reproducible: Always
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #528559 -
Flags: review?(surkov.alexander)
Comment 2•13 years ago
|
||
Comment on attachment 528559 [details] [diff] [review] MAKE SURE EACH FILE IN ATK/ HAS BOTH VIM AND EMACS LINES SETUP FOR 2 SPACE INDENTS Review of attachment 528559 [details] [diff] [review]: r=me
Attachment #528559 -
Flags: review?(surkov.alexander) → review+
Comment 3•13 years ago
|
||
landed - http://hg.mozilla.org/mozilla-central/rev/f9a978db8102
Assignee: nobody → trev.saunders
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
Comment 4•13 years ago
|
||
Thanks!
It doesn't work for me. I got Error detected while processing modelines: line 2: E518: Unknown option: */ It works if I change /* vim:expandtab:shiftwidth=2:tabstop=2: */ to /* vim:expandtab:shiftwidth=2:tabstop=2: */
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 6•13 years ago
|
||
Trevor, could you address comment #5 please?
Assignee | ||
Comment 7•13 years ago
|
||
(In reply to comment #6) > Trevor, could you address comment #5 please? Yeah, I notice the same issue too, I took a quick look and we had this issue in some files before, and I ended up just spreading it around all of atk/ :( https://developer.mozilla.org/En/Mozilla_Coding_Style_Guide suggests /* vim: set ts=2 et sw=2 tw=80: * which works for me, does it work for Ginn?
Assignee | ||
Comment 8•13 years ago
|
||
I used the vim configuration suggested in https://developer.mozilla.org/En/Developer_Guide/Coding_Style Ginn Fernando does this work for you? it seems to work for me.
Attachment #535766 -
Flags: review?(fherrera)
Updated•13 years ago
|
Attachment #535766 -
Flags: review?(fherrera) → review+
Assignee | ||
Comment 9•13 years ago
|
||
landed http://hg.mozilla.org/mozilla-central/rev/78ad95eaf1f1
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•