Closed
Bug 653145
Opened 13 years ago
Closed 13 years ago
move layout/xul/base/test/* mochitests to mochitest-chrome to avoid enablePrivileges
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jmaher, Assigned: jmaher)
References
Details
(Whiteboard: [specialpowers])
Attachments
(1 file, 1 obsolete file)
7.55 KB,
patch
|
bzbarsky
:
review+
jwkbugzilla
:
review+
|
Details | Diff | Splinter Review |
in the move to remove enablePrivilege with specialPowers, we have found that many tests don't make sense as mochitest plain. If any of these tests should be mochitest-plain, please speak up.
Assignee | ||
Updated•13 years ago
|
Attachment #528605 -
Flags: review?(ted.mielczarek)
Assignee | ||
Updated•13 years ago
|
Whiteboard: [specialpowers]
Comment 1•13 years ago
|
||
It's not clear to me that this makes sense for test_bug511075.html.
Comment 2•13 years ago
|
||
Can you r? the original test author(s)? I don't have the domain knowledge to say whether moving them to chrome will break anything.
Assignee: nobody → jmaher
Comment 3•13 years ago
|
||
Comment on attachment 528605 [details] [diff] [review] move layout/xul/base/test/* from mochitest-plain -> chrome (1.0) Review of attachment 528605 [details] [diff] [review]: ----------------------------------------------------------------- The mechanical changes look fine. Please get review from a peer on these tests so we can ensure that you're not breaking anything the tests are intended to test.
Attachment #528605 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 4•13 years ago
|
||
updated patch to remove test_resizer.xul (fails on osx and winxp) and test_splitter.xul (fails on winxp). These are passing on try server. I would like to get a review that these tests I am moving: /layout/xul/base/test/test_bug381167.xhtml /layout/xul/base/test/test_bug393970.xul /layout/xul/base/test/test_bug477754.xul /layout/xul/base/test/test_bug511075.html /layout/xul/base/test/test_stack.xul will still be testing the same functionality when run in the mochitest-chrome harness.
Attachment #528605 -
Attachment is obsolete: true
Attachment #534715 -
Flags: review?(bzbarsky)
Comment 5•13 years ago
|
||
Comment on attachment 534715 [details] [diff] [review] move layout/xul/base/test/* from mochitest-plain -> chrome (2.0) I honestly don't know. Looks to me like it should be ok, but if you want to be sure check with the test authors?
Attachment #534715 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 6•13 years ago
|
||
ehsan, can to look at test_bug477754.xul and make sure that it would be ok as a mochitest-chrome test. wladimir, cna you look at testUbug393970.xul and make sure that it would be ok as a mochitest-chrome test. Neil, can you verify test_stack.xul is safe to move to mochitest-chrome.
Comment 7•13 years ago
|
||
Comment on attachment 534715 [details] [diff] [review] move layout/xul/base/test/* from mochitest-plain -> chrome (2.0) Changing test_bug393970.xul seems fine to me, this test was about chrome UI in the first place.
Attachment #534715 -
Flags: review+
Assignee | ||
Comment 8•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/85394deb049d
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 9•13 years ago
|
||
(In reply to comment #6) > ehsan, can to look at test_bug477754.xul and make sure that it would be ok as a > mochitest-chrome test. Sorry for the delay here. FWIW, yes, this is fine.
You need to log in
before you can comment on or make changes to this bug.
Description
•